Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

withdraw2 task not being executed when withdrawAmount is <= 0 #1060

Open
rouzwelt opened this issue Dec 10, 2024 · 0 comments · May be fixed by #1082
Open

withdraw2 task not being executed when withdrawAmount is <= 0 #1060

rouzwelt opened this issue Dec 10, 2024 · 0 comments · May be fixed by #1082
Assignees
Labels
bug Something isn't working

Comments

@rouzwelt
Copy link
Contributor

rouzwelt commented Dec 10, 2024

atm, withdraw2 task is inside of an if block that checks if withdrawAmount is > 0, however bot relies on the task to ensure the bounty of the transaction, and because sometime the bounty can be 0 for one of the tokens, that ends up bypassing the task and as a result, bot fails to ensure the bounty check correctly resulting in negative bounty txs.

The withdraw2 task used to be outside of the if block, but since has been moved inside of it. Possible solution is to move it back outside of if block, although open to discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants