1060 withdraw2 task not being executed when withdrawamount is 0 #1082
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
atm, withdraw2 task is inside of an if block that checks if withdrawAmount is > 0, however bot relies on the task to ensure the bounty of the transaction, and because sometime the bounty can be 0 for one of the tokens, that ends up bypassing the task and as a result, bot fails to ensure the bounty check correctly resulting in negative bounty txs.
Solution
Write test to show the issue
Checks
By submitting this for review, I'm confirming I've done the following: