Skip to content

Commit

Permalink
optionrom/pvh: scan entire RSDP Area
Browse files Browse the repository at this point in the history
Right now the PVH option rom scans for the RSDP from 0xE0000 to
0xE1FFF. This is probobly a typo, it should scan from 0xE0000 to
0xFFFFF.

This is actually an issue on some QEMU versions/machines. For example,
when I run QEMU the RSDP is placed at 0xf5ad0 which will not be picked
up by the current implementation.

This bug still allows a Linux guest to boot (in most configurations) as
the kernel will just scan for the RSDP if one isn't provided.

Signed-off-by: Joe Richey <[email protected]>
Reviewed-by: Stefano Garzarella <[email protected]>
Fixes: 2785dc7 ("optionrom: add new PVH option rom")
Signed-off-by: Paolo Bonzini <[email protected]>
  • Loading branch information
josephlr authored and bonzini committed Mar 16, 2020
1 parent 4ce1e15 commit 770275e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pc-bios/optionrom/pvh_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ asm (".code32"); /* this code will be executed in protected mode */

#define RSDP_SIGNATURE 0x2052545020445352LL /* "RSD PTR " */
#define RSDP_AREA_ADDR 0x000E0000
#define RSDP_AREA_SIZE 2048
#define RSDP_AREA_SIZE 0x00020000
#define EBDA_BASE_ADDR 0x0000040E
#define EBDA_SIZE 1024

Expand Down

0 comments on commit 770275e

Please sign in to comment.