Skip to content

Recredit Frederik Spang #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Recredit Frederik Spang #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c8ce8a
Update canonical_names.rb
frederikspang Dec 28, 2024
7c560f7
Update canonical_names_test.rb
frederikspang Dec 28, 2024
edcec35
Update canonical_names_test.rb
frederikspang Dec 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/models/names_manager/canonical_names.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,7 @@ def self.map(canonical_name, *also_as)
map 'Franky Wahl', 'Franky W'
map 'Frederick Cheung', 'fcheung', 'Fred Cheung', 'frederick.cheung', "frederick.cheung\100gmail.com"
map 'Frederico Macedo', 'frederico'
map 'Frederik Spang', 'frederikspang', 'Frederik Erbs Spang Thomsen'
map 'G S Phani Kumar', 'gsphanikumar'
map 'Gabe da Silveira', 'dasil003'
map 'Gabriel Gironda', "gabriel.gironda\100gmail.com", "gabriel\100gironda.org"
Expand Down
5 changes: 5 additions & 0 deletions test/credits/canonical_names_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1574,6 +1574,11 @@ class CanonicalNamesTest < ActiveSupport::TestCase
test 'frederico' do
assert_contributor_names '11a75f9', 'Frederico Macedo'
end

test 'frederikspang' do
assert_contributor_names 'b602ffd', 'Frederik Spang'
assert_contributor_names '2acfed9', 'Frederik Spang'
end

test 'freels' do
assert_contributor_names '36b8073', 'Matt Freels'
Expand Down
Loading