Use standardrb for code formatting#574
Merged
andyundso merged 6 commits intorails-sqlserver:masterfrom Feb 4, 2025
Merged
Conversation
andyundso
force-pushed
the
standard-rb
branch
from
f9b42c3 to
29c114a
Compare
andyundso
force-pushed
the
standard-rb
branch
from
29c114a to
9bcc011
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #564
This PR replaces the old Rubocop configuration with
standardrb. I personally likestandardrbbetter since it requires 0 configuration to run. I also tried out the existing Rubocop configuration and it almost had as many corrections as this PR has.For review, best skip c4873cd as these include safe auto corrections, stuff like removing the encoding magic comment or replacing
'with". 3ae4fd1 contains a couple of unsafe corrections, which I manually checked all. This brought up some uncorrectable things in very old benchmark files, which I decided to remove.standardrbis also run on CI to enforce the coding style.