Select blocking webpage from browser history #107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #87.
This PR allows to users to add a page to the blocking list from the browser history. Since accessing the user's history needs the
historypermission, it adds this permission asoptional_permissionand users can opt-out any time in the browsers extension settings.The default behaviour is the regular interface, where users can add the url manually. However, there is a possibility to allow impulse-blocker to access the browser history (see image below) as the browser asks the user, if impulse-blocker can access the history.
Once the permission is granted, the input value is changed to a dropdown item.
As addressed by @raicem the urls appear multiple times. I couldn't get that fixed, so I decided to only show one item when typing in the dropdownbox. This can be changed, though.
And finally, once the permissions are revoked (e.g. the browser addon settings), the interface falls back into default.