Skip to content

fix: run with sudo for normal users #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guruswarupa wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: run with sudo for normal users #888

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion scripts/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,11 @@ main() {
else
log_info "Running 'nixopus install' with options: ${cli_args[*]}"
fi
nixopus install "${cli_args[@]}"
if [ $EUID -ne 0 ]; then
sudo nixopus install "${cli_args[@]}"
else
nixopus install "${cli_args[@]}"
fi
Comment on lines +430 to +434
Copy link
Collaborator

@zhravan zhravan Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets exit and throw error if not root.

For installing docker and setting related permissions for docker and docker daemon, we need root permission mandatorily.

nixopus install works fine if docker is already there, but if docker is not installed, then we have to run with sudo.

So advised to run it as sudo. If you check docs, here also by default we expect user to run the script with sudo.

Copy link
Contributor Author

@guruswarupa guruswarupa Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this escalation, normal users would fail midway because certain installs require root.

Copy link
Contributor Author

@guruswarupa guruswarupa Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even after we enter sudo password, it doesn't continue installation.
to fix that, sudo is added here.

log_success "nixopus install completed successfully!"
else
log_info "Skipping 'nixopus install' as requested..."
Expand Down