-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workspaces & Plans #129
Draft
raggesilver
wants to merge
25
commits into
main
Choose a base branch
from
staging
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Workspaces & Plans #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented endpoints and services for creating and updating workspaces. Refactored UI to include workspace creation modal and reorganized code structure for better readability and maintainability. Introduced new constants and validation schemas for workspaces.
Implemented new general, member, and rule settings components for workspace. Integrated useQueryParam composable for tab navigation and added corresponding tabs. Updated Nuxt config to use Tailwind compatibility reset CSS.
Added a computed property to check if form data is modified before submitting. Also integrated a utility function for consistent fetch error messages across the application.
Introduce `Checkbox.vue` and `coming-soon.vue` components. Enhance workspace settings by adding descriptions and `ComingSoon` placeholders. Update form error handling to use a utility function and improve type safety in various files.
raggesilver
had a problem deploying
to
staging
December 13, 2024 15:52 — with
GitHub Actions
Failure
raggesilver
had a problem deploying
to
staging
December 27, 2024 03:35 — with
GitHub Actions
Failure
raggesilver
had a problem deploying
to
staging
December 27, 2024 03:40 — with
GitHub Actions
Failure
raggesilver
commented
Dec 27, 2024
export default defineEventHandler(async (event) => { | ||
const { user: _user } = await requireUserSession(event); | ||
|
||
// TODO: verify if user has access to workspace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
Staging is currently broken because of this nodejs/import-in-the-middle#171 💩 |
We are now using MinIO for local development. This makes the set up easier to manage & inspect, reduces the amount of .env variables we need, and reduces the risk of accidently deleting something from production. We are also moving some S3-specific business logic into a service, which should make things cleaner and easier to migrate (if we ever need to) in the future.
This commit introduces a new Redis cache and some helper functions to speed up caching. Our first cached resource is the workspace usage query, which can be very expensive (as it sums the size of every attachment on a workspace).
- Removed unused "Share board" feature from workspace page. - Adjusted button attributes for improved consistency and style. - Added `encodeAttachmentName` utility for safe filename encoding. - Updated "Content-Disposition" handling for UTF-8 filenames. - Remove useless console log in Redis utility. - Added `onConflictDoNothing` for workspace collaborators insertion. This fixes users who accept invitations to workspaces they are already a part of.
- Introduced `WorkspaceMemberRow` to display individual collaborators. - Implemented `usePublicUser` composable for fetching user data. - Adjusted pricing page for improved collaborator limits messaging. - Updated member settings to use `WorkspaceMemberRow` for listing users. - Disabled animations in pricing page — they don't look good.
This bug has been plaguing me forever. We didn't insert newly created tasks into all necessary states, which caused the edit task form to not work properly.
Fucking nitro devs haven't fixed excessive stack depth for api return types in over two years.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's fix our initial mistake of naming boards "workspaces." Workspaces are now what they were always supposed to be: a collection of users and boards. This is the most basic requirement for us to start working on plans — which we must implement to charge for features that actively cost money to provide (i.e file uploads).