Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Appraisal and Active Record Tests #133

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Adds Appraisal and Active Record Tests #133

wants to merge 4 commits into from

Conversation

theomelo
Copy link

@theomelo theomelo commented Mar 6, 2025 •
edited
Loading

Closes: #120

  • Add and configure Appraisal.
  • Schedule rails_main tests to run independently from a PR push.
  • Configure GitHub Action to run against different Appraisal files:
    • Update .rspec to exclude specs in the ext directory.
    • Create a Rake task that will gather all gemfiles and run the command above with every gemfile.
    • Create a new action that will execute this new Rake task.
  • Add test coverage for lib/rage/ext/active_record/connection_pool.rb. Specifically:
    • ActiveRecord::Base.connection_pool.with_connection
    • ActiveRecord::Base.connection_pool.connection
    • ActiveRecord::Base.connection_pool.release_connection
    • ActiveRecord::Base.connection_pool.active_connection?

rsamoilov
rsamoilov reviewed Mar 6, 2025
View reviewed changes
Copy link
Member

@rsamoilov rsamoilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Theo, great job!

Have several comments right off the bat.

theomelo added 3 commits March 10, 2025 18:54
@theomelo
Add Appraisal gem
478a339
@theomelo
Run appraisals as a Github Action
9fbb32b 
- Don't run `spec/ext` as part of the default test suite
- Separate running appraisals against the main rails branch. Instead,
  run the main branch as a scheduled action.
- Add a new rake task to run all appraisals (except against main Rails branch)
@theomelo
Start adding tests
14fc1d2
@theomelo
Copy link
Author

theomelo commented Mar 11, 2025 •
edited
Loading

@rsamoilov I should've asked if you are against using force-push in your PRs before doing so here. I hope you don't mind. 🙇

I updated my PR with the changes you asked for; please let me know if I misunderstood anything. If the current changes are ok, I'll finish adding the tests for the connection_pool methods.

@theomelo theomelo requested a review from rsamoilov March 11, 2025 02:02
@rsamoilov
Copy link
Member

if you are against using force-push

Not at all.

rsamoilov
rsamoilov reviewed Mar 11, 2025
View reviewed changes
Copy link
Member

@rsamoilov rsamoilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks exactly as it should. Love it!

@rsamoilov
Copy link
Member

Oh, one more thing - let's remove the Appraisal file and the gemfiles directory from the bundle.

@theomelo
Fix Appraisals GH workflow and ignore gems folder
e5d4fdb 
- Remove EOL Ruby version
- Fix steps identation
- Add caching for Appraisals gems
- Remove Appraisals' gemfiles folder from `gemspec`
@theomelo theomelo requested a review from rsamoilov March 15, 2025 00:47
@theomelo
Copy link
Author

I updated the workflow to use the cache, but I don't know if it will work as expected. I'll wait for you to approve and fix any errors that might happen.

Another project workflow question: do you prefer having one commit per Pull Request (squash them before merge)?

@rsamoilov
Copy link
Member

do you prefer having one commit per Pull Request (squash them before merge)

No, don't worry about the git stuff. Doesn't matter to me.

And sorry for the required approvals, I don't think it's possible to disable that.

@rsamoilov
Copy link
Member

rsamoilov commented Mar 16, 2025 •
edited
Loading

Weird, it appears to be working, but it doesn't seem to change anything.
https://github.com/rage-rb/rage/actions/runs/13867738888/job/38848070523?pr=133

Screenshot 2025-03-16 at 15 28 27

@theomelo
Copy link
Author

And sorry for the required approvals, I don't think it's possible to disable that.

No worries! There's no reason to be sorry 🙏

Weird, it appears to be working, but it doesn't seem to change anything.
https://github.com/rage-rb/rage/actions/runs/13867738888/job/38848070523?pr=133

I'll investigate this today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsamoilov rsamoilov Awaiting requested review from rsamoilov

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🌶️ Active Record Tests
2 participants
@theomelo @rsamoilov