🌶️ Active Record Tests

[rsamoilov]

Description

Rage supports Active Record 6.0+, and being fully compatible with all relevant Active Record versions is a major goal for the framework.

Yet, the biggest missing piece in our test suite is test cases against different Active Record versions. Probably, the best tool to implement such kind of tests would be Appraisal.

Ideally, we would have a separate test suite that would run independently of the main test suite and would allow us to test parts of the framework that are dependent on external gems against different versions of those gems.

Let's start with covering the following methods with tests:

• ActiveRecord::Base.connection_pool.with_connection
• ActiveRecord::Base.connection_pool.connection
• ActiveRecord::Base.connection_pool.release_connection
• ActiveRecord::Base.connection_pool.active_connection?

Tips

• The methods mentioned earlier are defined in lib/rage/ext/active_record/connection_pool.rb.
• See how our tests are being run at the moment in .github/main.yml.
• Check the overview doc that shows how Rage's core components interact with each other.
• Feel free to ask any questions or request help in the comments below!

[theomelo]

I want to tackle this one 🙏

[rsamoilov]

Woohoo! Go for it! And let me know if there’s anything I can help with.

[theomelo]

I just opened a draft pull request so you can check if I'm on the right track. 🙏

Regarding this note:

Ideally, we would have a separate test suite that would run independently of the main test suite and would allow us to test parts of the framework that are dependent on external gems against different versions of those gems.

Does this mean you want a separate GitHub Action or Step to run these independently? Instead of changing line 36 from .github/workflows/main.yml to run with Appraisal, we would scope just the new tests from ActiveRecord. Is my assumption correct?

[rsamoilov]

Is my assumption correct?

Yes, that's right! I've commented on the PR.