VMS build update #474
VMS build update #474
Conversation
|
The CI test that failed was freebsd 13.2, and the relevant error was: pkg: No packages available to install matching 'openssl30' have been found in the repositoriesso it never actually got set up to build much less run a test. Sounds like that combination needs to be taken out of the list. |
Makefile.PL was initializing MakeMaker's CCFLAGS argument to
$Config{ccflags}, then manually appending -D switches to it. That
is not portable since not all compilers use that syntax for defines.
Luckily, MakeMaker knows how to parse compiler flags and inject
defines passed in -D format via its DEFINE argument. So use DEFINE
instead of CCFLAGS.
This test was failing on VMS because list assignment to %ENV is not allowed. So just override the slice of %ENV that the test is concerned with.
| # CCFLAGS is used internally by Makefile.PL to define various C preprocessor | ||
| # macros (as opposed to DEFINE, which is user-facing). | ||
| $eumm_args{CCFLAGS} = $Config{ccflags}; |
There was a problem hiding this comment.
SSLeay.xs currently says:
Lines 209 to 214 in 420b801
It would be good to leave DEFINE for command line use, as shown above, but I couldn't find an easy way to do this. In other words, passing defines to the compiler directly from Makefile.PL and also allowing additional defines defined on the command line. Would you happen to know a way to do this?
There was a problem hiding this comment.
I see what you mean. The MakeMaker docs seem pretty clear that you can send an attribute to WriteMakefile or you can make it an argument on the command line -- not both. The only alternative I can think of would be to parse off any DEFINEs found in @argv and add the concatenated result to the DEFINE that gets passed to WriteMakefile. That's not pretty but I can't think of anything better at the moment. Maybe inspiration will strike.
There was a problem hiding this comment.
Thanks! It seems your suggestion of looping through the ARGV is the easiest way. More exactly, loop through the ARGV in reverse order and push the Makefile.PL DEFINEs to the first found entry in the ARGV. Reverse it's a bit safer because even the latest MakeMaker seems to only consider the last DEFINE from the command line.
In case the command line has no DEFINE, pass the Makefile.PL DEFINEs directly to WriteMakefile().
|
These three commits are now merged. My intention was to merge them differently, but for some reason the branch protection did not hold and they went directly to the master branch. I'll need to check why this happens. I also added a commit that handles the case where DEFINE is also given as a command line argument when running |
No description provided.