-
Notifications
You must be signed in to change notification settings - Fork 4
Release 4.0.0 #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 4.0.0 #80
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces Delfino version 4.0.0, which includes breaking changes and modernization updates. The primary purpose is to drop support for Python 3.8 and modernize the codebase to use Python 3.9+ features, while also upgrading dependencies and tooling.
Key changes:
- Modernize type annotations using Python 3.9+ style generics and collections
- Add support for UV package manager detection
- Upgrade tooling from individual tools to consolidated ruff for linting and formatting
Reviewed Changes
Copilot reviewed 31 out of 37 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Updates version to 4.0.0, drops Python 3.8 support, upgrades dependencies, replaces old tooling configs with ruff |
| CHANGELOG.md | Documents breaking changes, new features, and fixes for 4.0.0 release |
| src/delfino/models/pyproject_toml.py | Adds BuildSystem and Project models, UV support, modernizes type annotations |
| src/delfino/utils.py | Implements UV package manager detection logic |
| tests/unit/test_utils.py | Adds comprehensive test coverage for package manager detection |
| Multiple source files | Modernizes type annotations from typing module to built-in generics |
| Multiple test files | Updates type annotations and improves code formatting |
| .pylintrc & tests/.pylintrc | Removes pylint configuration files (replaced by ruff) |
| .pre-commit-config.yaml | Updates formatting command from 'format' to 'ruff' |
Files not reviewed (4)
- .idea/delfino.iml: Language not supported
- .idea/misc.xml: Language not supported
- .idea/ruff.xml: Language not supported
- .idea/vcs.xml: Language not supported
|
|
||
| command_name: str = ctx.command.name or "" | ||
| value_from_config: str = getattr(app_context.plugin_config, command_name, {}).get(self.config_option_name, None) | ||
| value_from_config: str = getattr(app_context.plugin_config, command_name, {}).get(self.config_option_name, "") |
Copilot
AI
Aug 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default value was changed from None to an empty string, but the type annotation still indicates str. This could cause issues if the calling code expects None when no config value is found. Consider keeping None as the default or updating the type annotation to Optional[str].
| value_from_config: str = getattr(app_context.plugin_config, command_name, {}).get(self.config_option_name, "") | |
| value_from_config: Optional[str] = getattr(app_context.plugin_config, command_name, {}).get(self.config_option_name, None) |
3b34584 to
16f1bef
Compare
16f1bef to
a0a78ae
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
==========================================
+ Coverage 44.33% 46.26% +1.92%
==========================================
Files 22 22
Lines 627 642 +15
Branches 118 79 -39
==========================================
+ Hits 278 297 +19
+ Misses 342 338 -4
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-approved because this PR was opened by the repository owner and auto-merge is enabled.
No description provided.