-
-
Notifications
You must be signed in to change notification settings - Fork 53
migration part 1 #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migration part 1 #185
Conversation
Watermelon AI SummaryAI Summary deactivated by CCleanerShot GitHub PRs
ui is an open repo and Watermelon will serve it for free. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
=======================================
Coverage 90.62% 90.62%
=======================================
Files 5 5
Lines 32 32
Branches 8 4 -4
=======================================
Hits 29 29
Misses 3 3 ☔ View full report in Codecov by Sentry. |
some components skipped currently as they rely on tools components, which will be all done in a seperate migration
This reverts commit 2d03cf2.
|
|
||
| const COMPONENT_NAME = 'Badge'; | ||
|
|
||
| interface BadgeProps { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some of these dont have exports, will that work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should discuss on whether or not we want to export all interfaces.
i wasnt sure if there were any potential drawbacks from exposing all interfaces for users (alot may be redundant/confusing), but in terms of rad-ui development, it would make things easier, yes.
No description provided.