Skip to content

Conversation

@CCleanerShot
Copy link
Contributor

No description provided.

@watermelon-copilot-for-code-review
Copy link

watermelon-copilot-for-code-review bot commented Jan 5, 2024

Watermelon AI Summary

AI Summary deactivated by CCleanerShot

GitHub PRs

ui is an open repo and Watermelon will serve it for free.
🍉🫶

@codecov
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b4611e6) 90.62% compared to head (1c5d6e0) 90.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #185   +/-   ##
=======================================
  Coverage   90.62%   90.62%           
=======================================
  Files           5        5           
  Lines          32       32           
  Branches        8        4    -4     
=======================================
  Hits           29       29           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

some components skipped currently as they rely on tools components, which will be all done in a seperate migration

const COMPONENT_NAME = 'Badge';

interface BadgeProps {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some of these dont have exports, will that work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should discuss on whether or not we want to export all interfaces.

i wasnt sure if there were any potential drawbacks from exposing all interfaces for users (alot may be redundant/confusing), but in terms of rad-ui development, it would make things easier, yes.

@kotAPI kotAPI merged commit 2913617 into main Jan 6, 2024
@kotAPI kotAPI deleted the migration-typescript branch January 6, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants