Automated Resyntax fixes #1478
Open
Automated Resyntax fixes #1478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This `if`-`else` chain can be converted to a `cond` expression.
This `let` expression can be pulled up into multiple `define` expressions.
`cond` with internal definitions is preferred over `if` with `let`, to reduce nesting
This `if` expression can be refactored to an equivalent expression using `and`.
Internal definitions are recommended instead of `match-let` expressions with a single binding, to reduce nesting.
The `begin` form inside this `begin0` form can be extracted into the surrounding definition context.
This negated `when` expression can be replaced by an `unless` expression.
Use `raise-arguments-error` instead of `error` for better error messages that follow Racket conventions.
This `format` expression can be simplified to an equivalent `format-symbol` expression.
This use of `format` does nothing.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
jackfirth
reviewed
Nov 7, 2025
| ;; leq2: cx <= lexp2 | ||
| [(and (eqv? 0 a) (eqv? 0 d)) (leq (lexp-scale l1 c) (lexp-scale r2 b))] | ||
| [else (error 'leq-join "cannot join ~a and ~a by ~a" leq1 leq2 x)]))) | ||
| [else (raise-arguments-error 'leq-join "cannot join and by" "leq1" leq1 "leq2" leq2 "x" x)]))) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 20 issues in 10 files.
match-let-to-match-defineerror-to-raise-arguments-errorlet-to-definedefine-let-to-multi-defineif-else-false-to-andif-let-to-condbegin0-begin-extractionformat-string-to-format-symbolnested-if-to-condinverted-whenformat-identity