Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update broken redirect rules #647

Merged
merged 3 commits into from
Dec 14, 2016
Merged

Update broken redirect rules #647

merged 3 commits into from
Dec 14, 2016

Conversation

meker12
Copy link
Contributor

@meker12 meker12 commented Dec 14, 2016

Nexus control bug causes redirect rules with # character to generate an invalid URL.
(deconst/presenter#140).
This PR update product specific api.rackspace.com redirect targets
to remove anchor links. Updated rules direct legacy links to the home page of product API.

Nexus control bug causes redirect rules with # character to
generate an invalid URL. 
(deconst/presenter#140).
Update product specific api.rackspace.com redirect target
to remove anchor links. Updated targets
direct legacy links to the home page of product API.
@meker12 meker12 added the bug label Dec 14, 2016
@meker12 meker12 added this to the Milestone 21 milestone Dec 14, 2016
@meker12 meker12 self-assigned this Dec 14, 2016
@meker12 meker12 requested a review from catlook December 14, 2016 00:47
@meker12 meker12 requested review from kallimachos and removed request for catlook December 14, 2016 01:11
@meker12 meker12 changed the title Update broken redirect rulese Update broken redirect rules Dec 14, 2016
"toHostname": "developer.rackspace.com",
"rewrite": false,
"status": 302
"rewrite": false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the root redirect. Don't we need to keep the "toProtocol" and "toHostname" settings?

Copy link
Contributor

@kallimachos kallimachos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question inline.

@meker12
Copy link
Contributor Author

meker12 commented Dec 14, 2016

That was removed by mistake. Thanks for catching that.

@kallimachos kallimachos merged commit b9114ab into master Dec 14, 2016
@cyrichardson cyrichardson deleted the meker12-patch-3 branch April 14, 2017 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants