-
Notifications
You must be signed in to change notification settings - Fork 279
Update rustc-ap-syntax to 541.0 #1060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/racer/ast.rs
Outdated
let mut expr_visitor = ExprTypeVisitor::new(self.scope.clone(), self.session); | ||
expr_visitor.visit_expr(expr); | ||
self.rh_expr = expr_visitor.result; | ||
ExprKind::If(let_stmt, ..) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing ExprKind::While
or should this not process while let
s?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 👍, thanks
@kngwyu My apologies for annoyance, but could you use 542.0.0, please? I have just released rustfmt 1.4.1 w/ 542.0.0 to fix the build failure in the latest nightly. |
@topecongiro |
Awesome, thank you 💯 Could you cut a new release with the v542 bump? I'll use that to upgrade Racer and rustfmt to a single version in the RLS. |
Sure, I just opened #1061 |
@Xanewok |
Awesome, thank you! |
@kngwyu Thanks. But there are still errors when build from master
|
@jiacai2050 |
@kngwyu rustc 1.38.0-nightly (4560cb830 2019-07-28) compile fine. Many thanks. |
Resolves #1058
cc: @Xanewok @topecongiro