Skip to content

Update rustc-ap-syntax to 541.0 #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 30, 2019
Merged

Conversation

kngwyu
Copy link
Collaborator

@kngwyu kngwyu commented Jul 28, 2019

Resolves #1058
cc: @Xanewok @topecongiro

src/racer/ast.rs Outdated
let mut expr_visitor = ExprTypeVisitor::new(self.scope.clone(), self.session);
expr_visitor.visit_expr(expr);
self.rh_expr = expr_visitor.result;
ExprKind::If(let_stmt, ..) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing ExprKind::While or should this not process while lets?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍, thanks

@topecongiro
Copy link
Contributor

@kngwyu My apologies for annoyance, but could you use 542.0.0, please? I have just released rustfmt 1.4.1 w/ 542.0.0 to fix the build failure in the latest nightly.

@kngwyu
Copy link
Collaborator Author

kngwyu commented Jul 30, 2019

@topecongiro
Thank you for releasing, I've just updated it.

@kngwyu kngwyu merged commit 2584ca2 into racer-rust:master Jul 30, 2019
@kngwyu kngwyu deleted the rustc-ap541 branch July 30, 2019 07:58
@Xanewok
Copy link
Collaborator

Xanewok commented Jul 30, 2019

Awesome, thank you 💯 Could you cut a new release with the v542 bump? I'll use that to upgrade Racer and rustfmt to a single version in the RLS.

@kngwyu
Copy link
Collaborator Author

kngwyu commented Jul 30, 2019

Sure, I just opened #1061

@kngwyu
Copy link
Collaborator Author

kngwyu commented Jul 30, 2019

@Xanewok
Just published 2.1.24

@Xanewok
Copy link
Collaborator

Xanewok commented Jul 30, 2019

Awesome, thank you!

@jiacai2050
Copy link

@kngwyu Thanks. But there are still errors when build from master 7c313b3a142726b66006dae49b0c8d67b2877d70

error[E0425]: cannot find function `type_name` in module `any`
   --> /Users/chenxiang/.cargo/registry/src/mirrors.ustc.edu.cn-12df342d903acd47/rustc-ap-serialize-542.0.0/serialize.rs:852:21
    |
852 |                any::type_name::<S>(),
    |                     ^^^^^^^^^ not found in `any`
help: possible candidates are found in other modules, you can import them into scope
    |
7   | use core::intrinsics::type_name;
    |
7   | use std::intrinsics::type_name;
    |

error[E0425]: cannot find function `type_name` in module `any`
   --> /Users/chenxiang/.cargo/registry/src/mirrors.ustc.edu.cn-12df342d903acd47/rustc-ap-serialize-542.0.0/serialize.rs:854:21
    |
854 |                any::type_name::<T>(),
    |                     ^^^^^^^^^ not found in `any`
help: possible candidates are found in other modules, you can import them into scope
    |
7   | use core::intrinsics::type_name;
    |
7   | use std::intrinsics::type_name;
    |

   Compiling syn v0.15.42
error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0425`.

@kngwyu
Copy link
Collaborator Author

kngwyu commented Jul 30, 2019

@jiacai2050
You can reproduce it with the latest nightly?

@jiacai2050
Copy link

@kngwyu rustc 1.38.0-nightly (4560cb830 2019-07-28) compile fine. Many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build from master failed
4 participants