Skip to content

Management UI: fix MQTT qos0 queue [type] rendering #13981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

MarcialRosales
Copy link
Contributor

@MarcialRosales MarcialRosales commented May 30, 2025

Proposed Changes

Fix issue rendering mqtt qos0 queue type.

Although there is a selenium test that reproduces the issue (selenium/test/queuesAndStreams/view-mqtt-qos0.js) these are the reproduction steps:

  1. open an mqtt 5.0 connection with Session Expiry Interval of 0
  2. subscribe to a quorum queue using QoS 0
  3. Go to the management ui
  4. Go to the queue and Streams tab
  5. Click on the queue whose type is rabbit_mqtt_qos0_queue
  6. You get an exception

This issue is only reproducible on main. 4.1.x uses a different mechanism to render this type of queue.

There is another PR, #14014, which backports all the changes relative to selenium except the fix which is only applicable to main.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

@MarcialRosales MarcialRosales self-assigned this May 30, 2025
@MarcialRosales MarcialRosales changed the title Reproduce issue rendering mqtt qos0 queue type Mgt UI: Render mqtt qos0 queue type May 30, 2025
@MarcialRosales MarcialRosales force-pushed the selenium-test-mqtt-queue branch from 61d2139 to 4ef4f18 Compare May 30, 2025 12:22
@michaelklishin michaelklishin added this to the 4.2.0 milestone May 30, 2025
@michaelklishin michaelklishin changed the title Mgt UI: Render mqtt qos0 queue type Management UI: fix MQTT qos0 queue [type] rendering May 30, 2025
@MarcialRosales MarcialRosales force-pushed the selenium-test-mqtt-queue branch 3 times, most recently from acf0ed4 to a30f96e Compare June 3, 2025 07:05
@MarcialRosales MarcialRosales marked this pull request as ready for review June 3, 2025 07:25
@michaelklishin michaelklishin force-pushed the selenium-test-mqtt-queue branch from a30f96e to cc86ffe Compare June 3, 2025 12:41
@michaelklishin
Copy link
Collaborator

The forced push was a rebase on top of main to benefit from a CI fix in #14018.

@michaelklishin michaelklishin merged commit f7a238a into main Jun 3, 2025
558 of 560 checks passed
@michaelklishin michaelklishin deleted the selenium-test-mqtt-queue branch June 3, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants