Fix #13009, STOMP: default to exclusive queues except stream queues#13016
Merged
michaelklishin merged 6 commits intomainfrom Mar 23, 2026
Merged
Fix #13009, STOMP: default to exclusive queues except stream queues#13016michaelklishin merged 6 commits intomainfrom
michaelklishin merged 6 commits intomainfrom
Conversation
Collaborator
|
At least some, if not all, remaining failures seem repeatable and related. Specifically |
michaelklishin
force-pushed
the
ik-stomp-exclusive-subs-13009
branch
from
26e0e9c to
8aa7d40
Compare
Collaborator
|
The forced push was a rebase on top of |
The STOMP plugin still relies on `amqp_client` (for now), which cannot use `rabbit_vhost`, so we extract a new DQT resolution function that takes the virtual host DQT as an argument. The STOMP plugin then resolves the DQT using `rabbit_vhost` and `rabbit_registry`, passes it to `get_queue_type/2` and decides on the properties based on the canonicalized type name (a module name).
via `rabbit_vhost:default_queue_type/1`.
Contributor
|
The common module looks strange. IMO |
Collaborator
|
@ikavgo take a look where does |
Collaborator
|
I have more changes in the works. However, I think we can move In that case we wouldn't need this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
STOMP: default to exclusive queues except for quorum queues and streams.
Now that non-durable, non-exclusive queues are disabled by default, this
updates the STOMP plugin to use:
/queue/<name>: declares a durable, non-exclusive, non-auto-delete queue/topic/<name>(default): declares a transient, exclusive, auto-delete queue bound to the topic exchange/topic/<name>withdurable:trueandauto-delete:false: declares a durable, non-exclusive, non-auto-delete queue, allowing shared and resumable subscriptions/exchange/<name>/<routing-key>: declares a transient, exclusive, auto-delete queue bound to thenameexchange/temp-queue/<name>: declares a transient, exclusive, auto-delete queue/amq/queue/<name>and/reply-queue/<name>: nothing changes, these reference a pre-existing queueThis is a Breaking Change
For some STOMP destination types and clients that rely on all defaults, this is, at least technically, a breaking change.
However, so is the status quo: as of
4.3.0, non-durable, non-exclusive queues cannot be declared without opting out (a server reconfiguration), and that's exactly what the current STOMP plugin uses.