fix: update membership when reverting cluster change#609
Merged
kjnilsson merged 1 commit intorabbitmq:mainfrom Mar 26, 2026
Merged
fix: update membership when reverting cluster change#609kjnilsson merged 1 commit intorabbitmq:mainfrom
kjnilsson merged 1 commit intorabbitmq:mainfrom
Conversation
kjnilsson
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi — last one from me for now!
In
pre_append_log_follower, when a new leader overwrites a previously uncommitted cluster change entry, the first clause (the overwrite/revert path) updatesclusterback toprevious_clusterbut doesn't updatemembershipto match. The normal cluster change path in the second clause does call the membership update, so this is just a missing step in the revert path.The impact is small since membership gets corrected at apply time, but it keeps the two paths consistent.
Thanks for being so responsive with the reviews on all of these — really appreciate it!