-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use github actions to confirm and upload plugin details to db #285
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: cd9c0c9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Closed the old one since it brought in a bunch of commits from my test branch. |
async function getUpdatedPluginDetailsPaths(): Promise<string[]> { | ||
// compares the current HEAD with the previous commit to get the updated plugin details | ||
const { stdout, stderr } = await execAsync( | ||
"git diff --name-only HEAD^ HEAD -- 'packages/*plugin-details.yml'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fully tested this using multiple scenarios. It is working as intended.
Details
plugin-details.yml
file in the template.plugin-details.yml
file. If a new package is detected and there is no config, or the config is not valid, the action will fail.plugin-details.yml
to the staging and production api. The details will already be validated at this point.Backend Changes
Issues
When updating the config file with a new image url, it wont change the image on the S3 bucket unless you use a different name.Image updates do work, the old image is just cached for a while. 😀Testing
I have done a lot of testing locally.
Passes
Fails