Skip to content

Clarify that in-place edits are what makes a formatter work #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patcon wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Clarify that in-place edits are what makes a formatter work #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

A [Danger](https://github.com/danger/danger) plug-in to suggest code changes through inline comments in pull requests.

Suggestions are calculated based on the results of `git diff`, so any code formatter like rubocop, prettier, go fmt, etc. can be used for this.
Suggestions are calculated based on the results of `git diff`, so any code formatter that performs in-place edits (rubocop, prettier, go fmt, etc.) can be used for this.
Note that there is a limitation that multi-line replacements cannot be suggested because GitHub's suggested changes™ doesn't support it.

![demo](https://raw.githubusercontent.com/r7kamura/danger-suggester/master/images/demo.png)
Expand Down