Skip to content

Fix generating partially valid tokens #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattiasarro wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix generating partially valid tokens #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c6b8cb
ReTokenFilter.is_valid_token: partial=False
mattiasarro May 30, 2023
a9da752
fix handling of partial tokens
mattiasarro May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions rellm/rellm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,16 +40,22 @@ def complete_re(prompt:str, pattern: regex.Pattern | List[regex.Pattern], tokeni
)
new_token_ids = output_ids[0, prompt_length:]
output_text = tokenizer.decode(new_token_ids, skip_special_tokens=True)
partial_completion += output_text
prompt_plus_completion = prompt_plus_completion + output_text

for output_char in output_text:
partial_completion += output_char
prompt_plus_completion = prompt_plus_completion + output_char

if stop_after_match:
for p in pattern:
m = p.match(partial_completion)
if m and m.start() == 0:
if debug:
print("step={} completion={}".format(gen_tokens, partial_completion))
return m[0]

if debug:
print("step={} completion={}".format(gen_tokens, partial_completion))

if stop_after_match:
for p in pattern:
m = p.match(partial_completion)
if m and m.start() == 0:
return m[0]
gen_tokens += 1

return partial_completion