Skip to content

add proxy support #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

add proxy support #220

wants to merge 2 commits into from

Conversation

Yunuuuu
Copy link

@Yunuuuu Yunuuuu commented Mar 29, 2025

Fix #221. The title summarizes the aim of the PR.

@gaborcsardi
Copy link
Member

Thanks! But don't the libcurl proxy environment variables work already?

@Yunuuuu
Copy link
Author

Yunuuuu commented Mar 30, 2025

Since my network is heavily restricted due to my country's policies, I want to make usethis git-related functions work, which depend on gh and gert.

image

Having support for proxy environment variables in gh would be extremely useful, as usethis does not expose many arguments from gh or gert, making it difficult to configure network access directly.

I would really appreciate any advice on how to test whether the proxy environment variable is working correctly in gh. I couldn’t find any verbose argument for this—does one exist? Thanks in advance for your help!

@gaborcsardi
Copy link
Member

@Yunuuuu
Copy link
Author

Yunuuuu commented Apr 3, 2025

Thank you for the reference. I have checked both gh and gert in relation to the usethis::use_github_release() function. The function related to gh works well, but the one related to gert does not. It seems that gert does not respect the Git config proxy or the proxy environment variables. For me, it's safe to close this pull request. However, if you think it’s necessary, It's happy to merge it to provide additional arguments for controlling the proxy in gh directly. Thanks again for your help!

@gaborcsardi gaborcsardi closed this Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Add proxy support
2 participants