Set imageableArea through options in PrintImage.

[antoineveldhoven]

Fixes #1413

[antoineveldhoven]

Converted to draft; awaiting test results, will come back on this next week.

[tresf]

Thanks! Curious why copilot is spamming our tracker though. I've never seen this before and it's certainly not welcome on our tracker. Copilot typed more than the original PR description, it's pollution is not welcome and I'll block if from the repository if it continues.

[tresf]

we would like to specify the imageable area for printing images on custom paper sizes.

Do you mind filing a bug report describing what you're trying to achieve so that we can approach this PR from the same perspective as you? Currently we support printing images at their natural DPI and scaled to fit the paper. I assume you want something in between. If you can provide a use-case (sample image, paper size and a description of what it's not doing correctly) that'll help considerably in accepting this.

With regards to the PR, it's simple enough and should be pretty quick to review and merge. I'll tag @akberenz for a second set of eyes as she's been predominantly in charge of the 2D printing changes. For example, I wouldn't expect to have to reassign the Paper object the way it's done, but it's a copy of the PDF code so maybe Paper passed by value.

[antoineveldhoven]

we would like to specify the imageable area for printing images on custom paper sizes.

Do you mind filing a bug report describing what you're trying to achieve so that we can approach this PR from the same perspective as you? Currently we support printing images at their natural DPI and scaled to fit the paper. I assume you want something in between. If you can provide a use-case (sample image, paper size and a description of what it's not doing correctly) that'll help considerably in accepting this.

With regards to the PR, it's simple enough and should be pretty quick to review and merge. I'll tag @akberenz for a second set of eyes as she's been predominantly in charge of the 2D printing changes. For example, I wouldn't expect to have to reassign the Paper object the way it's done, but it's a copy of the PDF code so maybe Paper passed by value.

@tresf will do!
I probably have some time tomorrow to file a bug report with full details.

[antoineveldhoven]

Thanks! Curious why copilot is spamming our tracker though. I've never seen this before and it's certainly not welcome on our tracker. Copilot typed more than the original PR description, it's pollution is not welcome and I'll block if from the repository if it continues.

This is an option I have enabled; will turn it off, at least for this repo. Sorry for spamming

[antoineveldhoven]

@akberenz Thanks for your review and suggestions; let me do some testing regarding the scaling tomorrow.

[tresf]

Thanks! Curious why copilot is spamming our tracker though. I've never seen this before and it's certainly not welcome on our tracker. Copilot typed more than the original PR description, it's pollution is not welcome and I'll block if from the repository if it continues.

This is an option I have enabled; will turn it off, at least for this repo. Sorry for spamming

FWIW, I'm fine with the static code analysis (it did find a mistake after all), I just don't like a bot "summarizing" with more text than the PR, so please use as-needed, my response was probably overly harsh considering it caught a bug in the code changes.

[antoineveldhoven]

This PR aims to fix issue #1413

By supplying the size in the config we can specify the custom PageForm / ImageableArea.

const config = qz.configs.create(
      printer.model,
        {
            size: {
                // Force printer to use max width.
                width: printable.data.widthInch,
                height: printable.data.heightInch
            },
            scaleContent: false,
            units: 'in',
            density: printable.data.dpi
        }
    );
    const commands = [{
        type: "pixel",
        format: "image",
        flavor: "base64",
        data: printable.data.image,
        options: {
            pageWidth: printable.data.widthInch,
            pageHeight: printable.data.heightInch,
        }
    }];

    await qz.print(config, commands);

This results in the following image

debugging job-object in PrintPixel.printCopies() method, just before job.print() shows that the ImageableArea is as large as the custom page size