You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Create a MacCertificateInstaller similar to WindowsCertificateInstaller that leverages JNA and native system libraries for interacting with the computer certificate store.
This has some improvements that -- I believe -- are unrelated to this task and would make the PR easier to review if they were split out (e.g. removeAppLauncher, removeStartupEntry). @Vzor- can you please split this PR into two PRs so that we can take advantage of the refactor?
With regards to the Mac security stuff, I think it's still a good idea to add this if the efforts are fruitful. I understand that merging the Mac security stuff does not close #1076, however I believe the approach of using MacOS native libraries to be more professional approach at installing our certificates.
This has some improvements that -- I believe -- are unrelated to this task and would make the PR easier to review if they were split out (e.g. removeAppLauncher, removeStartupEntry). @Vzor- can you please split this PR into two PRs so that we can take advantage of the refactor?
With regards to the Mac security stuff, I think it's still a good idea to add this if the efforts are fruitful. I understand that merging the Mac security stuff does not close #1076, however I believe the approach of using MacOS native libraries to be more professional approach at installing our certificates.
Agreed. It may take a couple of days until I'm back on this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Create a
MacCertificateInstallersimilar toWindowsCertificateInstallerthat leverages JNA and native system libraries for interacting with the computer certificate store.Milestones
Related #1076, #841