Skip to content
This repository was archived by the owner on Mar 20, 2025. It is now read-only.

Add convenience data retrieval method to QXmppBitsOfBinaryDataList #475

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jbruechert
Copy link
Contributor

PR check list:

  • Document your code
  • Add \since QXmpp 1.X, QXMPP_EXPORT
  • Fix doxygen warnings (see log when building with -DBUILD_DOCUMENTATION=ON)
  • Update doc/doap.xml
  • Add unit tests
  • Format the code: Run clang-format -i src/<edited-file(s)> tests/<edited-file(s)>

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Base: 68.60% // Head: 68.24% // Decreases project coverage by -0.36% ⚠️

Coverage data is based on head (e62c02d) compared to base (f762f73).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #475      +/-   ##
==========================================
- Coverage   68.60%   68.24%   -0.37%     
==========================================
  Files         283      293      +10     
  Lines       24571    25108     +537     
==========================================
+ Hits        16857    17134     +277     
- Misses       7714     7974     +260     
Impacted Files Coverage Δ
src/base/QXmppBitsOfBinaryData.cpp 90.90% <0.00%> (-9.10%) ⬇️
src/base/QXmppBitsOfBinaryDataList.h 100.00% <ø> (ø)
src/base/QXmppFileShare.cpp 45.33% <0.00%> (-16.94%) ⬇️
src/base/QXmppUtils.cpp 81.98% <0.00%> (-4.69%) ⬇️
src/base/QXmppFileMetadata.cpp 50.87% <0.00%> (-1.51%) ⬇️
src/client/QXmppFileEncryption.cpp 67.44% <0.00%> (-1.07%) ⬇️
src/base/QXmppMessage.cpp 98.31% <0.00%> (-0.55%) ⬇️
tests/qxmppmessage/tst_qxmppmessage.cpp 94.82% <0.00%> (-0.02%) ⬇️
src/base/QXmppError.h 0.00% <0.00%> (ø)
src/base/QXmppError.cpp 0.00% <0.00%> (ø)
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@melvo
Copy link
Contributor

melvo commented Sep 29, 2022

@JBB There is a typo: It should be convenience :)

@jbruechert jbruechert changed the title Add convinience data retrieval method to QXmppBitsOfBinaryDataList Add convenience data retrieval method to QXmppBitsOfBinaryDataList Sep 29, 2022
@lnjX lnjX force-pushed the master branch 10 times, most recently from 84168ac to e614dcc Compare February 4, 2024 20:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants