This repository was archived by the owner on Mar 20, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 196
Add convenience data retrieval method to QXmppBitsOfBinaryDataList #475
Draft
jbruechert
wants to merge
2
commits into
qxmpp-project:master
Choose a base branch
from
jbruechert:bob-find
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b55d006
to
3611666
Compare
Codecov ReportBase: 68.60% // Head: 68.24% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #475 +/- ##
==========================================
- Coverage 68.60% 68.24% -0.37%
==========================================
Files 283 293 +10
Lines 24571 25108 +537
==========================================
+ Hits 16857 17134 +277
- Misses 7714 7974 +260
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
lnjX
reviewed
Sep 28, 2022
lnjX
reviewed
Sep 28, 2022
3611666
to
b38c9e3
Compare
b38c9e3
to
e101790
Compare
@JBB There is a typo: It should be convenience :) |
lnjX
reviewed
Sep 29, 2022
Co-authored-by: Linus Jahn <[email protected]>
84168ac
to
e614dcc
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR check list:
\since QXmpp 1.X
,QXMPP_EXPORT
-DBUILD_DOCUMENTATION=ON
)doc/doap.xml
clang-format -i src/<edited-file(s)> tests/<edited-file(s)>