Use dynamic min-height for reading view container #1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
osamasayed
reviewed
Jan 27, 2023
| @@ -91,6 +92,16 @@ const QuranReader = ({ | |||
| QURAN_READER_OBSERVER_ID, | |||
| ); | |||
|
|
|||
| const lines = useMemo( | |||
There was a problem hiding this comment.
There is an issue with this is that:
- For
ReadingView, the resource-intensive function ofgroupLinesByVerseswill be executed at least twice. One time here and another insidesrc/components/QuranReader/ReadingView/Page.tsx. - For
TranslationView, this adds extra calculations and won't be used sinceQuranReadercomponent is shared between both views.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We currently specify a
min-heightfor the reading view container to avoid CLS. However100vhdoesn't seem to fit shorter chapters. This PR takes a dynamic approach by taking the minimum of eitherthe number of lines * 20vhor100vh.Screenshots