Add new method for highlighting #1903
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ahmedriad1
changed the title
mmuminovic
reviewed
Feb 27, 2023
Comment on lines
+80
to
+91
| const renderWord = useCallback( | ||
| (word: Word) => ( | ||
| <QuranWord | ||
| key={word.location} | ||
| word={word} | ||
| font={quranFont} | ||
| isFontLoaded={isFontLoaded} | ||
| isHighlighted={word.verseKey === selectedVerseKey} | ||
| /> | ||
| ), | ||
| [quranFont, isFontLoaded, selectedVerseKey], | ||
| ); |
There was a problem hiding this comment.
What is the purpose of using useCallback here? It seems like it will rerender components regardless this useCallback function
There was a problem hiding this comment.
We're using it as a dependency in the highlighter's useMemo, so it's best practice to wrap it with a useCallback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, we pass
shouldShowSecondaryHighlightto the<QuranWord />component if we want to highlight a line or a verse. This approach results in weird gaps between the highlights. This PR uses a different approach:Excalidraw link
In short, this approach involves using an absolute
<div>with the highlight color as the background. The complex logic above is used to position the highlight accurately behind the verse.Screenshots