Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hydration error in QuranReader #1886

Open
wants to merge 3 commits into
base: upgrade-to-next-13
Choose a base branch
from

Conversation

ahmedriad1
Copy link
Collaborator

Summary

Error:

Jan-17-2023_15-09-04

This PR does the following:

  • Fix the hydration error above by dispatching setLastReadVerse after initial mount.
  • Lazy load SidebarNavigation in src/components/QuranReader/index.tsx.
  • Refactor some instances of typeof window !== 'undefined' to use our utility isClient.

@vercel
Copy link

vercel bot commented Jan 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
quran-com ✅ Ready (Inspect) Visit Preview Jan 17, 2023 at 6:41PM (UTC)

@ahmedriad1 ahmedriad1 changed the base branch from master to upgrade-to-next-13 January 21, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant