build: npm update, make update-lockfiles, cherry-pick various mintmaker updates#909
Open
mirekdlugosz wants to merge 8 commits intomainfrom
Open
build: npm update, make update-lockfiles, cherry-pick various mintmaker updates#909mirekdlugosz wants to merge 8 commits intomainfrom
mirekdlugosz wants to merge 8 commits intomainfrom
Conversation
The TypeScript compiler was throwing error TS2345 because the translation function expected specific types, but the use of logical AND (&&) operators with a numeric value caused type inference issues. Problem: When using `lastRefresh && 'load'`, TypeScript infers the type as `0 | "load"` rather than `"load" | undefined`, because lastRefresh is a number and the falsy value for numbers is 0, not undefined. The i18next translation function's type signature doesn't accept 0 as a valid value for these parameters. Solution: Changed from logical AND operators to ternary operators (`lastRefresh ? 'load' : undefined`) to ensure the types are explicitly either the intended values or undefined, matching what the translation library expects. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
The recent npm update (c49e86b) pulled in lodash 4.18.0, which contains a bug in its template function where `assignWith` is not defined. This caused html-webpack-plugin to fail during production builds with: "ReferenceError: assignWith is not defined at template". Fixed by adding a package override to pin lodash to the stable 4.17.23 version across all dependencies. This prevents the buggy 4.18.0 from being installed and allows the build and integration tests to pass. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
This functionally reverts d628ce2. We can't use lodash 4.17.x beause it contains security issues that make npm audit fail in CI.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates container base images and Tekton task bundles to newer digests, adjusts refresh-time button translation parameter handling, and refreshes associated lockfile and snapshot artifacts. Flow diagram for refresh time button translation parameter handlingflowchart TD
A["Render RefreshTimeButton"] --> B{lastRefresh > 0}
B -- Yes --> C["context = load"]
B -- No --> D["context = undefined"]
B -- Yes --> E["refresh = refresh (formatted time)"]
B -- No --> F["refresh = undefined"]
C --> G["t(refresh-time-button.refreshed, params)"]
D --> G
E --> G
F --> G
G --> H["Render translated last refresh message in button"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is #908 + one commit. Gotta keep them separated to see CI results without messing with main PR.
Summary by Sourcery
Update container base images, Tekton task bundles, and minor UI behavior for the refresh button.
Enhancements:
Build:
Tests: