Skip to content

Use strings.Builder for Post body scanning #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
igneel64 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use strings.Builder for Post body scanning #894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions reading-files.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -769,11 +769,11 @@ func newPost(postBody io.Reader) (Post, error) {

scanner.Scan() // ignore a line

buf := bytes.Buffer{}
var b strings.Builder
for scanner.Scan() {
fmt.Fprintln(&buf, scanner.Text())
fmt.Fprintln(&b, scanner.Text())
}
body := strings.TrimSuffix(buf.String(), "\n")
body := strings.TrimSuffix(b.String(), "\n")

return Post{
Title: title,
Expand Down Expand Up @@ -811,11 +811,11 @@ func newPost(postBody io.Reader) (Post, error) {

func readBody(scanner *bufio.Scanner) string {
scanner.Scan() // ignore a line
buf := bytes.Buffer{}
var b strings.Builder
for scanner.Scan() {
fmt.Fprintln(&buf, scanner.Text())
fmt.Fprintln(&b, scanner.Text())
}
return strings.TrimSuffix(buf.String(), "\n")
return strings.TrimSuffix(b.String(), "\n")
}
```

Expand Down
7 changes: 3 additions & 4 deletions reading-files/post.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package blogposts

import (
"bufio"
"bytes"
"fmt"
"io"
"strings"
Expand Down Expand Up @@ -40,9 +39,9 @@ func newPost(postBody io.Reader) (Post, error) {

func readBody(scanner *bufio.Scanner) string {
scanner.Scan() // ignore a line
buf := bytes.Buffer{}
var b strings.Builder
for scanner.Scan() {
fmt.Fprintln(&buf, scanner.Text())
fmt.Fprintln(&b, scanner.Text())
}
return strings.TrimSuffix(buf.String(), "\n")
return strings.TrimSuffix(b.String(), "\n")
}