Implement collect_block for lazy scorers.
#2728
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new API proposed in #2726 enables implementing
Collector::collect_block, which allows for slightly more efficient bulk pushes to theTopNComputerwhen aSegmentSortKeyComputer::is_lazy, and when scores are not required.We can:
It would additionally allow for bulk fetching (using
ColumnValues::first_vals) the first sort key column, as future work.I haven't benchmarked this yet! But
collect_blockis quite beneficial for aggregations.