TLSv1.3 test

[chrjohn]

Simple test against TLSv1.3...

[chrjohn]

@the-thing just one question if you could help me out with this. I simply tried to test if QFJ/MINA is able to use connections with TLS1.3. However, I ended up with a state where it sometimes worked, sometimes not.
Are you able to see the logs from the workflow runs? One time it works for a given JDK and OS and the next time it does not.
I get all kinds of errors intermittently:
SSLCertificateTest.shouldFailWhenUsingEmptyServerTrustore:548 Certificate was authenticated or
SSLCertificateTest.shouldFailIndividualSessionsWhenInvalidCertificatesUsed:444 Certificate was authenticated or
SSLCertificateTest.shouldFailIndividualSessionsWhenInvalidCertificatesUsed:440 Certificate was authenticated

Any idea what could cause this? Some kind of race condition?
Thank you in advance

[chrjohn]

When looking around, I realise that in the last weeks sometimes I get this error on all kind of different PR runs, e.g. for #919 or #920

SecureSocketTest.testLogonWithBadCertificate:78 no exception thrown

As far as I am aware it is always JDK17 that intermittently fails with that error.

[the-thing]

@chrjohn I will have a look.

BTW. I haven't built QuickFIX for a while locally and now I struggle to run unit tests from Intellij IDEA directly. It seems I can build with Maven, but I run out of memory when running single test case such SSLCertificateTest via IDEA. I forgot if there was something to change to run them locally.

[the-thing]

SecureSocketTest.testLogonWithBadCertificate:78 no exception thrown is most likely timeout but Certificate was authenticated doesn't look right.

[chrjohn]

@the-thing I don't use IntelliJ, for Netbeans the following works for me: https://github.com/quickfix-j/quickfixj#importing-the-project-into-the-ide
I can only imagine that it is trying to compile the whole message and field classes and that gives OOME. Here are the settings that are used when compiling at command line: https://github.com/quickfix-j/quickfixj/blob/master/.mvn/jvm.config

[the-thing]

Did you have any luck reproducing this issue locally? I am unable to do so.

I'm running Windows 11 Pro and I specifically downloaded Eclipse Temurin 17.0.13 and all the builds seem to pass. I'm running with mvn clean test -pl quickfixj-core -PskipAT,skipBundlePlugin or mvn clean test -pl quickfixj-core -PskipBundlePlugin

[chrjohn]

@the-thing , no cannot reproduce it locally. I was just puzzled that it fails pretty often with TLS1.3 but not with 1.2. Maybe a glitch in the github runners?