Only retrieve one batch of messages at a time when responding to a large ResendRequest#643
Open
philipwhiuk wants to merge 3 commits intoquickfix-j:masterfrom
Open
Only retrieve one batch of messages at a time when responding to a large ResendRequest#643philipwhiuk wants to merge 3 commits intoquickfix-j:masterfrom
philipwhiuk wants to merge 3 commits intoquickfix-j:masterfrom
Conversation
Member
|
@philipwhiuk do you happen to have the time to create a unit test for this? So we can ensure that normal resend processing works as expected? Probably a test where we resend more than 1000 messages and check that every message is resent. Something along that lines? |
This was referenced Feb 25, 2025
chrjohn
changed the title
chrjohn
reviewed
Feb 27, 2025
| try { | ||
| // QFJ-626 | ||
| msg = parseMessage(message); | ||
| if (msg.getException() != null) { |
Member
There was a problem hiding this comment.
@philipwhiuk I am not sure about this. This will not resend messages which were formerly (without this PR) sent. I mean we could discuss if it is sensible but I feel that this should be a separate change. WDYT?
generated by copilot, let's see what happens
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #639