Allow number of retries on failover#624
Open
MuhammadhAadhil wants to merge 3 commits intoquickfix-j:masterfrom
Open
Allow number of retries on failover#624MuhammadhAadhil wants to merge 3 commits intoquickfix-j:masterfrom
MuhammadhAadhil wants to merge 3 commits intoquickfix-j:masterfrom
Conversation
Member
|
thanks for the PR. In the meantime there was a request which is quite similar #402. See my comment there: #402 (comment) The question is: do you want to give it a try to introduce some kind of interface which enables users to customize the failover behaviour? The default behaviour could still have your changes with the number of retries (so we would have an improvement to the status quo). Cheers |
Author
|
Hi @chrjohn , It is an interesting change. Let me see on this and keep you posted. |
Author
|
Hi @chrjohn , May i know when this change will be added to the release. If there any more actions needed from my side, please be kind enough to guide me since this is my first change. |
Member
|
Hi @MuhammadhAadhil , do you wanted to consider the points from #624 (comment) ? |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #250
Enhancement.