Skip to content

Fixing NoopStore state reset - #1320

Merged
chrjohn merged 2 commits into
quickfix-j:masterfrom
the-thing:fixing-calendar-issue-for-noop-store
Sep 8, 2026
Merged

Fixing NoopStore state reset#1320
chrjohn merged 2 commits into
quickfix-j:masterfrom
the-thing:fixing-calendar-issue-for-noop-store

Conversation

@the-thing

Copy link
Copy Markdown
Collaborator

Fixes #1319

Changes

  • new calendar created on reset (similar to other stores)
  • renamed method to be more consistent with other stores

@codecov

codecov Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.57%. Comparing base (fd52fcb) to head (8d72fe2).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1320      +/-   ##
============================================
+ Coverage     70.46%   70.57%   +0.10%     
- Complexity     2249     2252       +3     
============================================
  Files           159      159              
  Lines          9065     9064       -1     
  Branches       1192     1192              
============================================
+ Hits           6388     6397       +9     
+ Misses         2214     2203      -11     
- Partials        463      464       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chrjohn

chrjohn commented Sep 8, 2026

Copy link
Copy Markdown
Member

@the-thing many thanks for your quick fix. 😄 👍

@chrjohn chrjohn added this to the QFJ 3.0.3 milestone Sep 8, 2026
@chrjohn
chrjohn merged commit a18c7a3 into quickfix-j:master Sep 8, 2026
14 checks passed
@the-thing
the-thing deleted the fixing-calendar-issue-for-noop-store branch September 8, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sessions on NoopStore keep resetting

2 participants