Improvements

[abhishekraha]

Changes :

1. Refactored code to remove unwanted object creation
2. Changed inner class to be static to avoid mem leakage
3. IntelliJ remove/regroup-imports and indentation
4. grammatical fixes

[abhishekraha]

redundant check as directory.mkdir() has exists check inbuilt

[abhishekraha]

non-static inner class will unnecessarily carry a reference to the outer class

[abhishekraha]

Arrays.asList(new SNIHostName(sniHostName)) - creates 2 objects

1. new SNIHostName(sniHostName)
2. Array object when we do Arrays.asList

Collections.singletonList(new SNIHostName(sniHostName)) - creates 1 object of SNIHostName and wraps it in the Collection obeject

[chrjohn]

Will check the other points, but this code is called typically only once. Good point, though.

[chrjohn]

Please roll back the import changes.

[abhishekraha]

Please roll back the import changes.

done.

out of curiosity - is the intention that we only import the classes that are required and not the whole package because importing is a compile time task and I don't think it has any latency implications.

[chrjohn]

out of curiosity - is the intention that we only import the classes that are required and not the whole package because importing is a compile time task and I don't think it has any latency implications.

The intention is simply that one uses IntelliJ, another uses Eclipse, a third Netbeans and either has its own taste of how imports should be organized (unless you configure it the same for all IDEs).

[abhishekraha]

out of curiosity - is the intention that we only import the classes that are required and not the whole package because importing is a compile time task and I don't think it has any latency implications.

The intention is simply that one uses IntelliJ, another uses Eclipse, a third Netbeans and either has its own taste of how imports should be organized (unless you configure it the same for all IDEs).

Got it. Thanks

I've reverted the import changes.

I didn't get much time after this initial one where my changes were around non-critical execution path which were called once maybe twice in the life cycle
I'll probably try to contribute to things that are more important in my next PR