fixup! target/hexagon: Initialize htid, modectl regs #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Cain <[email protected]>
Signed-off-by: Brian Cain <[email protected]>
The BADVA reg is referred to with the wrong identifier. The CAUSE reg field of SSR is not yet modeled, we will dump the SSR in a subsequent commit. Signed-off-by: Brian Cain <[email protected]>
Signed-off-by: Brian Cain <[email protected]>
Signed-off-by: Brian Cain <[email protected]>
Signed-off-by: Brian Cain <[email protected]>
…ags() Signed-off-by: Brian Cain <[email protected]>
Signed-off-by: Brian Cain <[email protected]>
Signed-off-by: Brian Cain <[email protected]>
Signed-off-by: Brian Cain <[email protected]>
These registers are defined in the Qualcomm Hexagon V71 Programmer's Reference Manual - https://docs.qualcomm.com/bundle/publicresource/80-N2040-51_REV_AB_Hexagon_V71_ProgrammerS_Reference_Manual.pdf Refer to §11.9.1 SYSTEM GUEST, §11.9.2 SYSTEM MONITOR. Signed-off-by: Brian Cain <[email protected]>
Signed-off-by: Brian Cain <[email protected]>
Signed-off-by: Brian Cain <[email protected]>
Signed-off-by: Brian Cain <[email protected]>
Signed-off-by: Brian Cain <[email protected]>
Signed-off-by: Brian Cain <[email protected]>
Also: add nop TCG overrides for break,unpause,fetchbo,dczeroa break: this hardware breakpoint instruction is used with the in-silicon debugger feature, this is not modeled. unpause: this instruction is used to resume hardware threads that are stalled by pause instructions. pause is modeled as a nop, or in RR mode as an EXCP_YIELD. This instruction is safe to ignore. Since cache/prefetch functions are not modeled, dczero and fetchbo are safe to ignore. Signed-off-by: Brian Cain <[email protected]>
This commit provides handlers to generate TCG for guest and system register reads and writes. They will be leveraged by a future commit. Signed-off-by: Brian Cain <[email protected]>
Signed-off-by: Brian Cain <[email protected]>
Signed-off-by: Brian Cain <[email protected]>
Signed-off-by: Brian Cain <[email protected]>
Define the register fields for ssr, schedcfg, stid, bestwait, ccr, modectl, imask, ipendad. Define the fields for TLB entries. Signed-off-by: Brian Cain <[email protected]>
Signed-off-by: Brian Cain <[email protected]>
Signed-off-by: Brian Cain <[email protected]>
Define TCG overrides for setprio(), crswap(,sgp{0,1,1:0}).
Signed-off-by: Brian Cain <[email protected]>
Signed-off-by: Brian Cain <[email protected]>
Define TCG overrides for {c,}swi {c,s}iad, iassign{r,w}, {s,g}etimask
instructions.
Signed-off-by: Brian Cain <[email protected]>
Define TCG overrides for start, stop, wait, resume instructions. Signed-off-by: Brian Cain <[email protected]>
Signed-off-by: Brian Cain <[email protected]>
Co-authored-by: Sid Manning <[email protected]> Signed-off-by: Brian Cain <[email protected]>
Signed-off-by: Marco Liebel <[email protected]>
Signed-off-by: Marco Liebel <[email protected]>
The number of parameters for `DEF_MACRO` changed and needed to be updated too. Signed-off-by: Marco Liebel <[email protected]>
Signed-off-by: Marco Liebel <[email protected]>
Signed-off-by: Marco Liebel <[email protected]>
Signed-off-by: Marco Liebel <[email protected]>
A single mapping is made by qct-qtimer.c and the extraneous region caused confusion. Signed-off-by: Sid Manning <[email protected]>
* TODO: forward the instruction tag to the unimp log? * TODO: why do we need_env() for these? * TODO: filter out some attributes? These instructions are unimplemented for now, they are used by h2.
Signed-off-by: Sid Manning <[email protected]>
Signed-off-by: Sid Manning <[email protected]>
SidManning
force-pushed
the
sidneym/fixup-28/38-Initialize_htid_modectl_regs
branch
from
78215fd to
d1de81a
Compare
target/hexagon/cpu.c
Outdated
Comment on lines
397
to
402
| if (cs->cpu_index == 0) { | ||
| memset(env->g_sreg, 0, sizeof(target_ulong) * NUM_SREGS); | ||
| } | ||
| memset(env->t_sreg, 0, sizeof(target_ulong) * NUM_SREGS); | ||
| memset(env->greg, 0, sizeof(target_ulong) * NUM_GREGS); | ||
|
|
||
| if (cs->cpu_index == 0) { | ||
| arch_set_system_reg(env, HEX_SREG_REV, cpu->rev_reg); | ||
| arch_set_system_reg(env, HEX_SREG_MODECTL, 0x1); | ||
| *(env->g_pcycle_base) = 0; | ||
| } |
There was a problem hiding this comment.
LGTM! But something that worries me a bit is if we start adding more statements inside this "if" in the future, not realizing that the arrays are reset to 0 below... What if we move the whole "if (cs->cpu_index == 0) { ... }" block right after the series of memset calls, just to be safe?
androm3da
force-pushed
the
hex-next
branch
6 times, most recently
from
a71a0dc to
eb2058b
Compare
androm3da
force-pushed
the
hex-next
branch
4 times, most recently
from
e4918c0 to
9db79fe
Compare
androm3da
force-pushed
the
hex-next
branch
2 times, most recently
from
723a8aa to
892d2ce
Compare
|
These changes are now incorporated into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.