Text align preferences added on Lyrics Mobile Server#147
Text align preferences added on Lyrics Mobile Server#147mbsrz1972 wants to merge 3 commits intoquelea-projection:masterfrom
Conversation
ArvidNy
left a comment
There was a problem hiding this comment.
Thanks, looks like a good addition to me! Haven't had the chance to test run this yet but the code looks alright to me. Personally I think I would prefer a separate function to be called from onchange on line 310 instead of having the two lines of JavaScript in the HTML code, but I suppose that's just a matter of preference.
However, I would prefer if you split the two changes (translation and new feature) into two pull requests instead. It's not a big deal, but it's always better to keep these kinds of changes apart so that we instantly can merge what does not need to be reviewed by us (translations) and comment on what has to be reviewed (new features).
Many thanks for the PR!
|
You seem to have misunderstood me about the labels, but if you resolve the conflict with the labels I can merge it. Just make sure to make a separate issue for updates to the language file in the future. |
Hi, I found it usefull for my needs so maybe you will. + Little polish language update