Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fips: Modified the postStart lifecycle hook to reference to sha256 (PROJQUAY-8185) #1002

Merged
merged 9 commits into from
Nov 8, 2024

Conversation

deshpandevlab
Copy link
Contributor

@deshpandevlab deshpandevlab commented Nov 7, 2024

Testing

  • manually verified PG upgrade

Copy link

openshift-ci bot commented Nov 7, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@deshpandevlab deshpandevlab marked this pull request as ready for review November 7, 2024 21:09
echo 'Waiting for PostgreSQL to start...';
sleep 2;
done;
if [ \"\$(cat /proc/sys/crypto/fips_enabled)\" -eq 1 ]; then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you may want to change this to something like if [[ -f /proc/sys/crypto/fips_enabled && $(< /proc/sys/crypto/fips_enabled) -eq 0 ]]; then so it checks for the file

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My linter says this results in "invalid escape sequence", i'm also getting an error saying it can't inflate this file

@openshift-merge-bot openshift-merge-bot bot merged commit 25bc2dc into quay:master Nov 8, 2024
11 checks passed
@bcaton85
Copy link
Collaborator

bcaton85 commented Nov 8, 2024

/cherry-pick redhat-3.13

@openshift-cherrypick-robot

@bcaton85: new pull request created: #1003

In response to this:

/cherry-pick redhat-3.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants