grant revoke change #1997
grant revoke change #1997
Conversation
benfdking
commented
Sep 17, 2025
benfdking
commented
- feat(snowflake): resource monitor statements
- feat(snowflake): alter procedure snowflake
- feat(snowflake): alter account statement
- feat(snowflake): implement the alter database
- feat(snowflake): improve create table defaults
- feat(snowflake): alter masking policy
- feat(snowflake): alter network policy
- feat(snowflake): grant revoke change
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| Ref::keyword("NOTIFY_USERS"), | ||
| Ref::new("EqualsSegment"), | ||
| Bracketed::new(vec_of_erased![Delimited::new(vec_of_erased![Ref::new( | ||
| "SingleIdentifierGrammar" | ||
| ),])]), |
There was a problem hiding this comment.
[P1] Allow string literals in NOTIFY_USERS option
The ResourceMonitorOptionsSegment models NOTIFY_USERS as Bracketed(Delimited(SingleIdentifierGrammar)). This only accepts unquoted identifiers, but the documented syntax for resource monitors requires string literals for each user, e.g. NOTIFY_USERS=('john.doe','ops_team'). With the current grammar, any valid statement that quotes the names (or uses email‑style identifiers) fails to parse even though Snowflake accepts it. Consider permitting QuotedLiteralSegment (and possibly identifiers) in the delimited list so both quoted and unquoted user names are handled.
Useful? React with 👍 / 👎.
