Skip to content

[PoC] rule: category/java/bestpractices.xml/MissingOverride #48169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

Pankraz76
Copy link

@Pankraz76 Pankraz76 commented Jun 1, 2025

facing 1200 modules is a lot to oversee all code. Static code analysis will enable common standards driven by the developers. This PoC aims to integrate PMD and then build up from there to the needs of the community.

Trying to achieve lately convention over configuration simply applying https://pmd.github.io/pmd/pmd_rules_jsp_errorprone.html could help align development.

@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/jdbc Issues related to the JDBC extensions area/kubernetes area/panache area/platform Issues related to definition and interaction with Quarkus Platform area/redis area/rest area/vertx labels Jun 1, 2025
Copy link

quarkus-bot bot commented Jun 1, 2025

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • description should not be empty, describe your intent or provide links to the issues this PR is fixing (using Fixes #NNNNN) or changelogs

This message is automatically generated by a bot.

@Pankraz76 Pankraz76 changed the title PoC: integrate PMD Maven Plugin [PoC] rule: category/java/bestpractices.xml/MissingOverride Jun 1, 2025
.jekyll-cache
.mvn/.develocity
.mvn/.gradle-enterprise/
.pmd/.cache
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new one.

.graal-install
dumps
*.iml
*.log
Copy link
Author

@Pankraz76 Pankraz76 Jun 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next one includes this right?

xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://pmd.sourceforge.net/ruleset/2.0.0 https://pmd.sourceforge.io/ruleset_2_0_0.xsd">
<!-- <rule ref="category/java/bestpractices.xml/MissingOverride" />-->
<rule ref="category/java/codestyle.xml/UnnecessaryImport" />
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://pmd.sourceforge.net/ruleset/2.0.0 https://pmd.sourceforge.io/ruleset_2_0_0.xsd">
<!-- <rule ref="category/java/bestpractices.xml/MissingOverride" />-->
Copy link
Author

@Pankraz76 Pankraz76 Jun 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/jdbc Issues related to the JDBC extensions area/kubernetes area/panache area/platform Issues related to definition and interaction with Quarkus Platform area/redis area/rest area/vertx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant