SmallRye GraphQL 2.12.0 #45228

jmartisk · 2024-12-20T10:52:46Z

https://github.com/smallrye/smallrye-graphql/tree/2.12.0

github-actions · 2024-12-20T11:32:09Z

🎊 PR Preview 93eb395 has been successfully built and deployed to https://quarkus-pr-main-45228-preview.surge.sh/version/main/guides/

Images of blog posts older than 3 months are not available.
Newsletters older than 3 months are not available.

jmartisk · 2024-12-20T11:32:53Z

Ok it seems this needs a change in the quickstarts: quarkusio/quarkus-quickstarts#1483

geoand · 2024-12-20T12:23:27Z

The gradle test failure seems related:

Error:  Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 8.795 s <<< FAILURE! -- in io.quarkus.gradle.ConditionalDependenciesKotlinTest
Error:  io.quarkus.gradle.ConditionalDependenciesKotlinTest.buildProject -- Time elapsed: 8.787 s <<< FAILURE!
java.lang.AssertionError: Gradle build failed with exit code 1
	at app//io.quarkus.gradle.QuarkusGradleWrapperTestBase.runGradleWrapper(QuarkusGradleWrapperTestBase.java:140)
	at app//io.quarkus.gradle.QuarkusGradleWrapperTestBase.runGradleWrapper(QuarkusGradleWrapperTestBase.java:57)
	at app//io.quarkus.gradle.QuarkusGradleWrapperTestBase.runGradleWrapper(QuarkusGradleWrapperTestBase.java:52)
	at app//io.quarkus.gradle.ConditionalDependenciesKotlinTest.buildProject(ConditionalDependenciesKotlinTest.java:15)
	at [email protected]/java.lang.reflect.Method.invoke(Method.java:569)
	at [email protected]/java.util.ArrayList.forEach(ArrayList.java:1511)
	at [email protected]/java.util.ArrayList.forEach(ArrayList.java:1511)

gsmet · 2024-12-20T12:51:26Z

I pushed a small fix for the Gradle failures.

gsmet · 2024-12-20T20:17:53Z

I'm making progress on fixing the issues. I think we might have to upgrade Gradle too.

gsmet · 2024-12-20T20:27:55Z

Even Gradle 8.12 released today isn't compatible with Kotlin 2.1.0: https://docs.gradle.org/current/userguide/compatibility.html#kotlin .

So I suppose this will have to wait.

Failure is:

shouldNotFailOnProjectDependenciesWithoutMain(Path)

org.gradle.testkit.runner.UnexpectedBuildFailure: Unexpected build execution failure in /tmp/junit16339159363799182023 with arguments [quarkusGenerateCode, --stacktrace]

Output:

FAILURE: Build failed with an exception.

* Where:
Build file '/tmp/junit16339159363799182023/mpp/build.gradle.kts' line: 11

* What went wrong:
'org.gradle.internal.buildoption.BuildOption$Value org.gradle.api.internal.StartParameterInternal.getIsolatedProjects()'

* Try:
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.

* Exception is:
java.lang.NoSuchMethodError: 'org.gradle.internal.buildoption.BuildOption$Value org.gradle.api.internal.StartParameterInternal.getIsolatedProjects()'
	at org.jetbrains.kotlin.gradle.plugin.internal.ProjectIsolationStartParameterAccessorG76$isProjectIsolationEnabled$2.invoke(ProjectIsolationStartParameterAccessorG76.kt:16)
	at org.jetbrains.kotlin.gradle.plugin.internal.ProjectIsolationStartParameterAccessorG76$isProjectIsolationEnabled$2.invoke(ProjectIsolationStartParameterAccessorG76.kt:15)
	at kotlin.SynchronizedLazyImpl.getValue(LazyJVM.kt:74)
	at org.jetbrains.kotlin.gradle.plugin.internal.ProjectIsolationStartParameterAccessorG76.isProjectIsolationEnabled(ProjectIsolationStartParameterAccessorG76.kt:15)
	at org.jetbrains.kotlin.gradle.plugin.internal.ProjectIsolationStartParameterAccessorKt.isProjectIsolationEnabled(ProjectIsolationStartParameterAccessor.kt:45)
	at org.jetbrains.kotlin.gradle.plugin.statistics.BuildFusService$Companion.registerIfAbsentImpl(BuildFusService.kt:94)
	at org.jetbrains.kotlin.gradle.plugin.statistics.BuildFusService$Companion.registerIfAbsent(BuildFusService.kt:80)
	at org.jetbrains.kotlin.gradle.plugin.DefaultKotlinBasePlugin.apply(KotlinPluginWrapper.kt:75)
	at org.jetbrains.kotlin.gradle.plugin.KotlinBasePluginWrapper.apply(KotlinPluginWrapper.kt:197)
	at org.jetbrains.kotlin.gradle.plugin.KotlinMultiplatformPluginWrapper.apply(PluginWrappers.kt:74)
	at org.jetbrains.kotlin.gradle.plugin.KotlinMultiplatformPluginWrapper.apply(PluginWrappers.kt:68)
	at org.gradle.api.internal.plugins.ImperativeOnlyPluginTarget.applyImperative(ImperativeOnlyPluginTarget.java:54)
	at org.gradle.api.internal.plugins.RuleBasedPluginTarget.applyImperative(RuleBasedPluginTarget.java:51)
	at org.gradle.api.internal.plugins.DefaultPluginManager.addPlugin(DefaultPluginManager.java:190)

gsmet · 2024-12-20T20:29:31Z

@jmartisk is SmallRye GraphQL 2.12.0 compatible with current main? If so, I think we should probably update in main and keep this PR for the Kotlin update.

I will also create a separate PR for the Gradle update as I think we want it anyway.

quarkus-bot · 2024-12-20T20:58:17Z

Status for workflow `Quarkus Documentation CI`

This is the status report for running Quarkus Documentation CI on commit cbec954.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

jmartisk · 2024-12-22T16:46:31Z

Do you know what version of Kotlin we can upgrade to?
SmallRye GraphQL bundles org.jetbrains.kotlin:kotlin-metadata-jvm 2.1.0. It also depends on kotlin compiler 2.1.0 but that is only used in tests, so I think that if Quarkus upgrades to a lower version of Kotlin, it should still work, but we probably do need kotlin-metadata-jvm 2.0+ (1.x definitely won't work because they've changed Java package names)

mschorsch · 2024-12-29T12:08:53Z

Even Gradle 8.12 released today isn't compatible with Kotlin 2.1.0: https://docs.gradle.org/current/userguide/compatibility.html#kotlin .

So I suppose this will have to wait.

Failure is:

shouldNotFailOnProjectDependenciesWithoutMain(Path)

org.gradle.testkit.runner.UnexpectedBuildFailure: Unexpected build execution failure in /tmp/junit16339159363799182023 with arguments [quarkusGenerateCode, --stacktrace]

Output:

FAILURE: Build failed with an exception.

* Where:
Build file '/tmp/junit16339159363799182023/mpp/build.gradle.kts' line: 11

* What went wrong:
'org.gradle.internal.buildoption.BuildOption$Value org.gradle.api.internal.StartParameterInternal.getIsolatedProjects()'

* Try:
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.

* Exception is:
java.lang.NoSuchMethodError: 'org.gradle.internal.buildoption.BuildOption$Value org.gradle.api.internal.StartParameterInternal.getIsolatedProjects()'
	at org.jetbrains.kotlin.gradle.plugin.internal.ProjectIsolationStartParameterAccessorG76$isProjectIsolationEnabled$2.invoke(ProjectIsolationStartParameterAccessorG76.kt:16)
	at org.jetbrains.kotlin.gradle.plugin.internal.ProjectIsolationStartParameterAccessorG76$isProjectIsolationEnabled$2.invoke(ProjectIsolationStartParameterAccessorG76.kt:15)
	at kotlin.SynchronizedLazyImpl.getValue(LazyJVM.kt:74)
	at org.jetbrains.kotlin.gradle.plugin.internal.ProjectIsolationStartParameterAccessorG76.isProjectIsolationEnabled(ProjectIsolationStartParameterAccessorG76.kt:15)
	at org.jetbrains.kotlin.gradle.plugin.internal.ProjectIsolationStartParameterAccessorKt.isProjectIsolationEnabled(ProjectIsolationStartParameterAccessor.kt:45)
	at org.jetbrains.kotlin.gradle.plugin.statistics.BuildFusService$Companion.registerIfAbsentImpl(BuildFusService.kt:94)
	at org.jetbrains.kotlin.gradle.plugin.statistics.BuildFusService$Companion.registerIfAbsent(BuildFusService.kt:80)
	at org.jetbrains.kotlin.gradle.plugin.DefaultKotlinBasePlugin.apply(KotlinPluginWrapper.kt:75)
	at org.jetbrains.kotlin.gradle.plugin.KotlinBasePluginWrapper.apply(KotlinPluginWrapper.kt:197)
	at org.jetbrains.kotlin.gradle.plugin.KotlinMultiplatformPluginWrapper.apply(PluginWrappers.kt:74)
	at org.jetbrains.kotlin.gradle.plugin.KotlinMultiplatformPluginWrapper.apply(PluginWrappers.kt:68)
	at org.gradle.api.internal.plugins.ImperativeOnlyPluginTarget.applyImperative(ImperativeOnlyPluginTarget.java:54)
	at org.gradle.api.internal.plugins.RuleBasedPluginTarget.applyImperative(RuleBasedPluginTarget.java:51)
	at org.gradle.api.internal.plugins.DefaultPluginManager.addPlugin(DefaultPluginManager.java:190)

https://kotlinlang.org/docs/whatsnew21.html#gradle-improvements

Kotlin 2.1.0 is fully compatible with Gradle 7.6.3 through 8.6. Gradle versions 8.7 to 8.10 are also supported
...
You can also use Gradle versions up to the latest Gradle release, but if you do, keep in mind that you might encounter deprecation warnings or some new Gradle features might not work.

gsmet · 2024-12-29T12:12:12Z

Well, we have to figure our why we are getting this error then.

mschorsch · 2024-12-31T09:27:51Z

I've found https://stackoverflow.com/questions/75284382/upgrade-gradle-7-4-to-8-0-rc-1 and
https://issuetracker.google.com/issues/254049155.
Maybe this is a problem with the AGP Version? I don't know :)

Doesnt make sense

jmartisk · 2025-01-02T07:52:58Z

I'm removing the Kotlin upgrade from this PR then, let's see if it works

jmartisk · 2025-01-02T13:22:07Z

Ok so I'm assuming we will keep this just for the SmallRye GraphQL update after all, as that should work without the Kotlin upgrade, and take care of the Kotlin+Gradle upgrade separately once we figure it out

quarkus-bot · 2025-01-02T14:02:34Z

Status for workflow `Quarkus CI`

This is the status report for running Quarkus CI on commit d8576e6.

Failing Jobs

Status	Name	Step	Failures	Logs	Raw logs	Build scan
✔️	JVM Tests - JDK 17			Logs	Raw logs	🔍
✔️	JVM Tests - JDK 21			Logs	Raw logs	🔍
✖	JVM Tests - JDK 17 Windows	`Build`	⚠️ Check →	Logs	Raw logs	🚧

You can consult the Develocity build scans.

geoand

Thanks!

quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/graphql area/smallrye labels Dec 20, 2024

jmartisk mentioned this pull request Dec 20, 2024

Update Kotlin to version 2.1.0 #44809

Closed

jmartisk force-pushed the srgql-2.12.0 branch from e8f0fa5 to fba4cf5 Compare December 20, 2024 10:55

This comment has been minimized.

Sign in to view

jmartisk mentioned this pull request Dec 20, 2024

Upgrade Kotlin to 2.1.0 quarkusio/quarkus-quickstarts#1483

Open

gsmet force-pushed the srgql-2.12.0 branch from fba4cf5 to 6286a11 Compare December 20, 2024 12:51

This comment has been minimized.

Sign in to view

gsmet force-pushed the srgql-2.12.0 branch from 6286a11 to 92425dd Compare December 20, 2024 13:44

This comment has been minimized.

Sign in to view

quarkus-bot bot added the triage/flaky-test label Dec 20, 2024

gsmet force-pushed the srgql-2.12.0 branch from 92425dd to cbec954 Compare December 20, 2024 20:27

quarkus-bot bot added area/kotlin area/platform Issues related to definition and interaction with Quarkus Platform labels Dec 20, 2024

This comment has been minimized.

Sign in to view

gsmet mentioned this pull request Dec 26, 2024

Upcoming Kotlin 2.1.x version looks to be breaking on compiler CLI API #45286

Closed

jmini mentioned this pull request Dec 30, 2024

make sure that @GraphQLClientApi attributes can be overriden by quarkus config #44441

Merged

mskacelik added 2 commits January 2, 2025 08:41

SmallRye GraphQL Update to 2.12.0

521c7b1

Fixed test where "data":null field is present during an error

d8576e6

jmartisk force-pushed the srgql-2.12.0 branch from cbec954 to d8576e6 Compare January 2, 2025 07:42

jmartisk changed the title ~~SmallRye GraphQL 2.12.0 and Kotlin 2.1~~ SmallRye GraphQL 2.12.0 Jan 2, 2025

geoand approved these changes Jan 3, 2025

View reviewed changes

jmartisk merged commit 45ae423 into quarkusio:main Jan 3, 2025
51 of 52 checks passed

jmartisk deleted the srgql-2.12.0 branch January 3, 2025 07:28

quarkus-bot bot added this to the 3.18 - main milestone Jan 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SmallRye GraphQL 2.12.0 #45228

SmallRye GraphQL 2.12.0 #45228

jmartisk commented Dec 20, 2024 •

edited

Loading

This comment has been minimized.

github-actions bot commented Dec 20, 2024 •

edited

Loading

jmartisk commented Dec 20, 2024

geoand commented Dec 20, 2024

gsmet commented Dec 20, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

gsmet commented Dec 20, 2024

gsmet commented Dec 20, 2024

gsmet commented Dec 20, 2024

quarkus-bot bot commented Dec 20, 2024

This comment has been minimized.

jmartisk commented Dec 22, 2024 •

edited

Loading

mschorsch commented Dec 29, 2024

gsmet commented Dec 29, 2024

mschorsch commented Dec 31, 2024 •

edited

Loading

jmartisk commented Jan 2, 2025

jmartisk commented Jan 2, 2025

quarkus-bot bot commented Jan 2, 2025 •

edited by github-actions bot

Loading

geoand left a comment

SmallRye GraphQL 2.12.0 #45228

SmallRye GraphQL 2.12.0 #45228

Conversation

jmartisk commented Dec 20, 2024 • edited Loading

This comment has been minimized.

github-actions bot commented Dec 20, 2024 • edited Loading

jmartisk commented Dec 20, 2024

geoand commented Dec 20, 2024

gsmet commented Dec 20, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

gsmet commented Dec 20, 2024

gsmet commented Dec 20, 2024

gsmet commented Dec 20, 2024

quarkus-bot bot commented Dec 20, 2024

Status for workflow Quarkus Documentation CI

This comment has been minimized.

jmartisk commented Dec 22, 2024 • edited Loading

mschorsch commented Dec 29, 2024

gsmet commented Dec 29, 2024

mschorsch commented Dec 31, 2024 • edited Loading

jmartisk commented Jan 2, 2025

jmartisk commented Jan 2, 2025

quarkus-bot bot commented Jan 2, 2025 • edited by github-actions bot Loading

Status for workflow Quarkus CI

Failing Jobs

geoand left a comment

Choose a reason for hiding this comment

jmartisk commented Dec 20, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024 •

edited

Loading

Status for workflow `Quarkus Documentation CI`

jmartisk commented Dec 22, 2024 •

edited

Loading

mschorsch commented Dec 31, 2024 •

edited

Loading

quarkus-bot bot commented Jan 2, 2025 •

edited by github-actions bot

Loading

Status for workflow `Quarkus CI`