Revise CI workflow #914
Draft
Revise CI workflow #914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the recent changes in other files to use cmake 3.28.
Some additional Python files need to be changed too.
This allows us to test with Python 3.14.
The revised CI workflow adds linting of workflows via actionlint. This config file tells actionlint that one of the runner names it doesn't recognize by default is actually valid.
Splitting up the previous workflows into separate files did work, but on balance, I find the disadvantages outweigh the advantages. The modularity of the separate files approach was good for reducing cognitive load and making maintenance a little bit easier, but it also decreased overall execution efficiency because the organization I used required more jobs. This new single file `ci.yaml` puts all the CI checks into one place, and adds some additional lint jobs compared to the previous set of workflow files. Note: this `ci.yaml` file does not have the wheel-building steps that the previous setup had. The wheel builds and PyPI uploads will be reintroduced in an upcoming separate workflow.
This defines a reusable action for installing and configuring Bazel. It's called from steps in the new `ci.yaml` file.
We're not building wheels, so `library-tests` does not need to set the `MACOSX_DEPLOYMENT_TARGET` variable for cibuildwheel.
Another simplification.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
It's probably a bad idea to only execute the library and build tests if there seem to be code changes; it's too easy for something unexpected to slip through. So the new logic is much simpler: only stop early if format or lint checks fail, and otherwise continue.
Right now, the repo lacks a pylintrc file, and therefore pylint's behavior is not as desired.
Currently getting access errors on GitHub runners. Hopefully this will fix it.
It would take more work to be able to compile qsim on Arm-based Linux systems. I'm removing it for now.
There's a simpler way to do it.
Seems to be broken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.