Update copyright checker and switch to pylint-3 #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow patch version updates at fixed minor version 3.3.
Follow the `examples/custom_raw.py` in the pylint repository.
Executed bash dev_tools/requirements/re-pip-compile-in-docker.sh
|
pylint-3 exposes some new lint - https://github.com/quantumlib/Qualtran/actions/runs/11189026244/job/31108808890 |
|
what's the deal with the |
mpharrigan
approved these changes
Oct 7, 2024
I checked one of such instances - Bloq.signature is an abstract property which is replaced by attrs field, but not redefined in its CompositeBloq subclass. I suspect pylint checks for a property named "signature", but |
shab5
pushed a commit
that referenced
this pull request
Oct 7, 2024
* Bump up to the latest pylint-3.3.1 * Adjust `pylint_copyright_checker` for the pylint-3 API Follow the `examples/custom_raw.py` in the pylint repository. * Refresh development dependencies * Temporarily disable rules that started failing in pylint-3 Cherry-picked from quantumlib/Cirq#6751 Related to #1440
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump up to the latest pylint-3.3.1
Adjust
pylint_copyright_checkerfor the pylint-3 APIFollow the
examples/custom_raw.pyin the pylint repository.Refresh development dependencies
Temporarily disable rules that started failing in pylint-3
Cherry-picked from quantumlib/Cirq#6751
Related to #1440