-
Notifications
You must be signed in to change notification settings - Fork 227
fix: hotfix for zip2 2.6.0 breaking changes #2652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
Preview - Build & Deploy Images✅ Build images 🕒 Last deployed: Apr 03, 2025 at 09:45 PM UTC |
…into ayush/fix_ci_zip2
zip = { git = "https://github.com/zip-rs/zip2", rev = "77cde6a" } | ||
|
||
[patch.'https://github.com/zip-rs/zip'] | ||
zip = { git = "https://github.com//zip-rs/zip2", rev = "77cde6a" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be a duplicate forward slash in the GitHub URL. The URL should be https://github.com/zip-rs/zip2
instead of https://github.com//zip-rs/zip2
. This typo appears in multiple patch sections throughout the PR.
zip = { git = "https://github.com//zip-rs/zip2", rev = "77cde6a" } | |
zip = { git = "https://github.com/zip-rs/zip2", rev = "77cde6a" } |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## qa #2652 +/- ##
==========================================
- Coverage 90.41% 0 -90.42%
==========================================
Files 383 0 -383
Lines 86288 0 -86288
==========================================
- Hits 78014 0 -78014
+ Misses 8274 0 -8274 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
[patch.'https://github.com/zip-rs/zip2'] | ||
zip = { git = "https://github.com//zip-rs/zip2", rev = "77cde6a" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an inconsistency in the patch URL configuration. In this file, the patch URL is specified as [patch.'https://github.com/zip-rs/zip2']
, while in other files it's configured as [patch.'https://github.com/zip-rs/zip']
.
This inconsistency could lead to dependency resolution issues. Consider updating this to match the pattern used in the other files:
[patch.'https://github.com/zip-rs/zip']
zip = { git = "https://github.com/zip-rs/zip2", rev = "77cde6a" }
Also note the double slash in the git URL (https://github.com//zip-rs/zip2
), which should be corrected to a single slash.
[patch.'https://github.com/zip-rs/zip2'] | |
zip = { git = "https://github.com//zip-rs/zip2", rev = "77cde6a" } | |
[patch.'https://github.com/zip-rs/zip'] | |
zip = { git = "https://github.com/zip-rs/zip2", rev = "77cde6a" } |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Description
fixes failing CI builds due to breaking changes in zip2 2.6.0
ref: