Skip to content

fix: hotfix for zip2 2.6.0 breaking changes #2652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 3, 2025
Merged

Conversation

AyushAgrawal-A2
Copy link
Collaborator

@AyushAgrawal-A2 AyushAgrawal-A2 commented Apr 3, 2025

Description

fixes failing CI builds due to breaking changes in zip2 2.6.0

ref:

Copy link

qa-wolf bot commented Apr 3, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link
Contributor

github-actions bot commented Apr 3, 2025

Preview - Build & Deploy Images

✅ Build images
✅ Deploy images

🕒 Last deployed: Apr 03, 2025 at 09:45 PM UTC

🔗 URL: https://ayush-fix-ci-zip2.quadratic-preview.com

@github-actions github-actions bot temporarily deployed to preview-pr-2652 April 3, 2025 20:54 Destroyed
zip = { git = "https://github.com/zip-rs/zip2", rev = "77cde6a" }

[patch.'https://github.com/zip-rs/zip']
zip = { git = "https://github.com//zip-rs/zip2", rev = "77cde6a" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be a duplicate forward slash in the GitHub URL. The URL should be https://github.com/zip-rs/zip2 instead of https://github.com//zip-rs/zip2. This typo appears in multiple patch sections throughout the PR.

Suggested change
zip = { git = "https://github.com//zip-rs/zip2", rev = "77cde6a" }
zip = { git = "https://github.com/zip-rs/zip2", rev = "77cde6a" }

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (77e33da) to head (f1f3c7b).
Report is 8 commits behind head on qa.

Additional details and impacted files
@@            Coverage Diff             @@
##               qa   #2652       +/-   ##
==========================================
- Coverage   90.41%       0   -90.42%     
==========================================
  Files         383       0      -383     
  Lines       86288       0    -86288     
==========================================
- Hits        78014       0    -78014     
+ Misses       8274       0     -8274     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot temporarily deployed to preview-pr-2652 April 3, 2025 21:05 Destroyed
Comment on lines +60 to +61
[patch.'https://github.com/zip-rs/zip2']
zip = { git = "https://github.com//zip-rs/zip2", rev = "77cde6a" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an inconsistency in the patch URL configuration. In this file, the patch URL is specified as [patch.'https://github.com/zip-rs/zip2'], while in other files it's configured as [patch.'https://github.com/zip-rs/zip'].

This inconsistency could lead to dependency resolution issues. Consider updating this to match the pattern used in the other files:

[patch.'https://github.com/zip-rs/zip']
zip = { git = "https://github.com/zip-rs/zip2", rev = "77cde6a" }

Also note the double slash in the git URL (https://github.com//zip-rs/zip2), which should be corrected to a single slash.

Suggested change
[patch.'https://github.com/zip-rs/zip2']
zip = { git = "https://github.com//zip-rs/zip2", rev = "77cde6a" }
[patch.'https://github.com/zip-rs/zip']
zip = { git = "https://github.com/zip-rs/zip2", rev = "77cde6a" }

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@github-actions github-actions bot temporarily deployed to preview-pr-2652 April 3, 2025 21:15 Destroyed
@AyushAgrawal-A2 AyushAgrawal-A2 merged commit 6a25ea7 into qa Apr 3, 2025
21 checks passed
@AyushAgrawal-A2 AyushAgrawal-A2 deleted the ayush/fix_ci_zip2 branch April 3, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants