Remove Discrod bridge - #287
Merged
Merged
Conversation
As PPTide made a plugin to be used as a Discord bridge, embedding that feature in Devzat is no longer needed. Furthermore removing the isBrige flag would make the code easier to maintain.
This was mainly to remove the unnecessary discordgo dependency.
Contributor
|
Do you want to add a link to my repo in the admin manual? https://github.com/PPTide/devzatDiscord (The github push mirror) |
Collaborator
Author
That's not a bad idea. Maybe we should create a section of the manual to list all known plugins and libraries around them. What do you think about that? |
Contributor
|
That seems like a pretty good idea!
…On 16.06.26 16:36, Maxime Bouillot wrote:
*Arkaeriit* left a comment (quackduck/devzat#287)
<#287 (comment)>
Do you want to add a link to my repo in the admin manual?
https://github.com/PPTide/devzatDiscord (The github push mirror)
That's not a bad idea. Maybe we should create a section of the manual
to list all known plugins and libraries around them. What do you think
about that?
—
Reply to this email directly, view it on GitHub
<#287?email_source=notifications&email_token=AMRDWWBGDHPSUPIU5W6TVYD5AFLNNA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZRHE4TGNBZGY22M4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4719934965>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMRDWWBDQZQBK6SLOOZKEDT5AFLNNAVCNFSNUABFKJSXA33TNF2G64TZHMZTKNBVGE2TIMJSHNEXG43VMU5TINRWGUYDQNBWGQ2KC5QC>.
You are receiving this because you commented.Message ID:
***@***.***>
|
Collaborator
Author
I added it in this PR. |
That way, the existence of a Discord bridge is still mentioned.
Arkaeriit
force-pushed
the
no-discord-bridge
branch
from
June 16, 2026 22:21
d9d7d6a to
1f54afd
Compare
Collaborator
Author
|
I'm merging, we can always revert if things go boom. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As PPTide made a Discord bridge plugin, there is no need to keep it embedded in Devzat.
If we remove the Slack bridge in a subsequent PR, we could remove the
isBridgeflag to make the code cleaner.