1341 Drop position from fold callbacks #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelhkay
added
XQFO
michaelhkay
force-pushed
the
1341-drop-position-callback-from-fold-functions
branch
from
ed49cc8 to
9ed13d6
Compare
| first forming the sequence <code>$input ! {'position': position(), 'item': .}</code> | ||
| and then applying the <function>fn:fold-left</function> function to this sequence. | ||
| (This idiom is frequently used within this specification in defining the formal equivalents | ||
| of other functions such as <function>fn:filter</function>.)</p> |
There was a problem hiding this comment.
Not anymore, I assume, thanks to using fn:for-each.
ChristianGruen
approved these changes
Mar 14, 2025
michaelhkay
added
Tests Added
|
The CG agreed to merge this PR at meeting 114 |
michaelhkay
added
the
Completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on issue 1341, we decided to drop the position argument from the 4 fold functions.
Most of the changes in this PR are dealing with the collateral damage - changes to "formal equivalents" of other functions that previously relied on fold-left having the position available to the callback function.