Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1086 Editorial changes to array:values #1087

Merged
merged 1 commit into from
Apr 30, 2024
Merged

1086 Editorial changes to array:values #1087

merged 1 commit into from
Apr 30, 2024

Conversation

michaelhkay
Copy link
Contributor

Fix #1086

@michaelhkay michaelhkay added XQFO An issue related to Functions and Operators Editorial Minor typos, wording clarifications, example fixes, etc. labels Mar 15, 2024
ChristianGruen
ChristianGruen requested changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@ChristianGruen ChristianGruen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we the description for array:values is revised this way, the same should probably be done for map:values.

@ChristianGruen
Copy link
Contributor

If #1094 (comment) is pushed further, the functions should be renamed to array:contents and map:contents.

@ChristianGruen
Copy link
Contributor

Related: #1169, with the suggestion to rename the functions to array:items and map:items.

@ChristianGruen ChristianGruen mentioned this pull request Apr 30, 2024
Closed
@ndw
Copy link
Contributor

ndw commented Apr 30, 2024

The CG agreed to merge this PR at meeting 075.

@ndw ndw merged commit 22339f0 into qt4cg:master Apr 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianGruen ChristianGruen ChristianGruen requested changes

Assignees
No one assigned
Labels
Editorial Minor typos, wording clarifications, example fixes, etc. XQFO An issue related to Functions and Operators
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

array:values spec cleanup
3 participants
@michaelhkay @ChristianGruen @ndw