Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

Fixed typing issues #44

Merged
merged 1 commit into from
May 13, 2024
Merged

Fixed typing issues #44

merged 1 commit into from
May 13, 2024

Conversation

qstokkink
Copy link
Owner

@qstokkink qstokkink commented May 8, 2024 •
edited
Loading

This PR:

  • Adds a PR check for mypy.
  • Fixes the remaining ruff errors in torrents.py.
  • Fixes all issues reported by mypy.
  • Updates the unit test runners to use Python 3.9.

How to run from TriblerExperimental directory:

mypy -p src.tribler.core

@qstokkink qstokkink changed the title ON HOLD: Fixed typing issues WIP: Fixed typing issues May 8, 2024
@qstokkink qstokkink force-pushed the fix_mypy branch 7 times, most recently from 40c002d to 354eedf Compare May 8, 2024 10:59
@qstokkink qstokkink changed the title WIP: Fixed typing issues READY: Fixed typing issues May 8, 2024
@qstokkink qstokkink marked this pull request as ready for review May 8, 2024 11:04
@qstokkink qstokkink changed the title READY: Fixed typing issues WIP: Fixed typing issues May 13, 2024
@qstokkink qstokkink marked this pull request as draft May 13, 2024 11:42
@qstokkink qstokkink force-pushed the fix_mypy branch 3 times, most recently from 55a24b5 to b8b7df6 Compare May 13, 2024 11:52
@qstokkink qstokkink changed the title WIP: Fixed typing issues READY: Fixed typing issues May 13, 2024
@qstokkink qstokkink marked this pull request as ready for review May 13, 2024 11:54
@qstokkink qstokkink requested a review from egbertbouman May 13, 2024 11:54
@qstokkink qstokkink requested a review from egbertbouman May 13, 2024 13:18
@qstokkink qstokkink changed the title READY: Fixed typing issues Fixed typing issues May 13, 2024
@qstokkink qstokkink merged commit f6278d6 into highlander May 13, 2024
5 checks passed
@qstokkink qstokkink deleted the fix_mypy branch May 13, 2024 14:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@egbertbouman egbertbouman egbertbouman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qstokkink @egbertbouman